]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
drm/panthor: Don't try to enable extract events
authorBoris Brezillon <boris.brezillon@collabora.com>
Fri, 28 Nov 2025 09:48:33 +0000 (10:48 +0100)
committerBoris Brezillon <boris.brezillon@collabora.com>
Fri, 28 Nov 2025 09:56:44 +0000 (10:56 +0100)
Not only this only works once, because of how extract events work
(event is enabled if the req and ack bit differ, and it's signalled
by the FW by setting identical req and ack, to re-enable the event,
we need to toggle the bit, which we never do). But more importantly,
we never do anything with this event, so we're better off dropping it
when programming the CS slot.

v2:
- Add R-b

v3:
- Collect R-b

Reviewed-by: Steven Price <steven.price@arm.com>
Reviewed-by: Chia-I Wu <olvaffe@gmail.com>
Link: https://patch.msgid.link/20251128094839.3856402-3-boris.brezillon@collabora.com
Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com>
drivers/gpu/drm/panthor/panthor_sched.c

index 5b2ab963ac99cfd55c797db907ccab651eab68c2..5ec553818c28f3084e1757065e6d96874383c5e2 100644 (file)
@@ -1180,12 +1180,10 @@ cs_slot_prog_locked(struct panthor_device *ptdev, u32 csg_id, u32 cs_id)
        panthor_fw_update_reqs(cs_iface, req,
                               CS_IDLE_SYNC_WAIT |
                               CS_IDLE_EMPTY |
-                              CS_STATE_START |
-                              CS_EXTRACT_EVENT,
+                              CS_STATE_START,
                               CS_IDLE_SYNC_WAIT |
                               CS_IDLE_EMPTY |
-                              CS_STATE_MASK |
-                              CS_EXTRACT_EVENT);
+                              CS_STATE_MASK);
        if (queue->iface.input->insert != queue->iface.input->extract)
                queue_resume_timeout(queue);
 }