]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
firmware: efi: Never declare sysfb_primary_display on x86
authorThomas Zimmermann <tzimmermann@suse.de>
Thu, 2 Apr 2026 09:09:16 +0000 (11:09 +0200)
committerArd Biesheuvel <ardb@kernel.org>
Wed, 8 Apr 2026 14:09:11 +0000 (16:09 +0200)
The x86 architecture comes with its own instance of the global
state variable sysfb_primary_display. Never declare it in the EFI
subsystem. Fix the test for CONFIG_FIRMWARE_EDID accordingly.

Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Fixes: e65ca1646311 ("efi: export sysfb_primary_display for EDID")
Signed-off-by: Ard Biesheuvel <ardb@kernel.org>
drivers/firmware/efi/efi-init.c

index 5a595d026f58e087f8ba9697b4904daac9e8f7b4..6103b1a082d2470f3799ea393bdd368abbe434bf 100644 (file)
@@ -60,7 +60,7 @@ extern __weak const efi_config_table_type_t efi_arch_tables[];
  * x86 defines its own instance of sysfb_primary_display and uses
  * it even without EFI, everything else can get them from here.
  */
-#if !defined(CONFIG_X86) && (defined(CONFIG_SYSFB) || defined(CONFIG_EFI_EARLYCON)) || defined(CONFIG_FIRMWARE_EDID)
+#if !defined(CONFIG_X86) && (defined(CONFIG_SYSFB) || defined(CONFIG_EFI_EARLYCON) || defined(CONFIG_FIRMWARE_EDID))
 struct sysfb_display_info sysfb_primary_display __section(".data");
 EXPORT_SYMBOL_GPL(sysfb_primary_display);
 #endif