]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
platform/chrome: cros_ec_typec: Init mutex in Thunderbolt registration
authorTzung-Bi Shih <tzungbi@kernel.org>
Tue, 5 May 2026 05:34:03 +0000 (05:34 +0000)
committerTzung-Bi Shih <tzungbi@kernel.org>
Wed, 6 May 2026 02:14:33 +0000 (02:14 +0000)
cros_typec_register_thunderbolt() missed initializing the `adata->lock`
mutex.  This leads to a NULL dereference when the mutex is later
acquired (e.g. in cros_typec_altmode_work()).

Initialize the mutex in cros_typec_register_thunderbolt() to fix the
issue.

Cc: stable@vger.kernel.org
Fixes: 3b00be26b16a ("platform/chrome: cros_ec_typec: Thunderbolt support")
Reviewed-by: Benson Leung <bleung@chromium.org>
Reviewed-by: Abhishek Pandit-Subedi <abhishekpandit@chromium.org>
Link: https://lore.kernel.org/r/20260505053403.3335740-1-tzungbi@kernel.org
Signed-off-by: Tzung-Bi Shih <tzungbi@kernel.org>
drivers/platform/chrome/cros_typec_altmode.c

index 557340b53af03b42b77a84ce0766e10372a85f15..66c546bf89b532d3bae1de322a1cfb1205e0190f 100644 (file)
@@ -359,6 +359,7 @@ cros_typec_register_thunderbolt(struct cros_typec_port *port,
        }
 
        INIT_WORK(&adata->work, cros_typec_altmode_work);
+       mutex_init(&adata->lock);
        adata->alt = alt;
        adata->port = port;
        adata->ap_mode_entry = true;