- Review fix for number of detached states due to use of variable

  after end of loop.

diff --git a/doc/Changelog b/doc/Changelog
index 878ea3aa7985c9e08754f0e28cdd7605fd16f3d3..a9c23bcab7fab739dd2853f890b3f01c9537eb11 100644 (file)
--- a/doc/Changelog
+++ b/doc/Changelog
@@ -7,6 +7,8 @@
          with.
        - Fix for mesh accounting when rpz decides to drop a reply with a
          tcp stream waiting for it.
+       - Review fix for number of detached states due to use of variable
+         after end of loop.
 
 24 June 2020: Wouter
        - iana portlist updated.

diff --git a/services/mesh.c b/services/mesh.c
index 12f861c7b50d6a4107881863336c6cd61181f2b9..922e6b32ee8126b8245cb3f00a706aa6a14a11be 100644 (file)
--- a/services/mesh.c
+++ b/services/mesh.c
@@ -1992,7 +1992,7 @@ mesh_serve_expired_callback(void* arg)
        }
        if(mstate->reply_list) {
                mstate->reply_list = NULL;
-               if(!mstate->reply_list && !mstate->cb_list && r) {
+               if(!mstate->reply_list && !mstate->cb_list) {
                        log_assert(mesh->num_reply_states > 0);
                        mesh->num_reply_states--;
                        if(mstate->super_set.count == 0) {