]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
crypto: qce - fix goto jump in error path
authorBartosz Golaszewski <bartosz.golaszewski@linaro.org>
Tue, 3 Dec 2024 09:19:29 +0000 (10:19 +0100)
committerHerbert Xu <herbert@gondor.apana.org.au>
Sat, 14 Dec 2024 09:21:43 +0000 (17:21 +0800)
If qce_check_version() fails, we should jump to err_dma as we already
called qce_dma_request() a couple lines before.

Cc: stable@vger.kernel.org
Fixes: ec8f5d8f6f76 ("crypto: qce - Qualcomm crypto engine driver")
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
drivers/crypto/qce/core.c

index e228a31fe28dc0a9053043952f9d1f75426bfcf1..58ea93220f0156d12f9af44fe6460582e47c56b7 100644 (file)
@@ -247,7 +247,7 @@ static int qce_crypto_probe(struct platform_device *pdev)
 
        ret = qce_check_version(qce);
        if (ret)
-               goto err_clks;
+               goto err_dma;
 
        spin_lock_init(&qce->lock);
        tasklet_init(&qce->done_tasklet, qce_tasklet_req_done,