]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
media: c8sectpfe: Add of_node_put() when breaking out of loop
authorLiang He <windhl@126.com>
Tue, 19 Jul 2022 14:10:23 +0000 (22:10 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 7 Jan 2023 11:07:20 +0000 (12:07 +0100)
[ Upstream commit 63ff05a1ad242a5a0f897921c87b70d601bda59c ]

In configure_channels(), we should call of_node_put() when breaking
out of for_each_child_of_node() which will automatically increase
and decrease the refcount.

Fixes: c5f5d0f99794 ("[media] c8sectpfe: STiH407/10 Linux DVB demux support")
Signed-off-by: Liang He <windhl@126.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/media/platform/sti/c8sectpfe/c8sectpfe-core.c

index 06e2cfd09855fa4d8e5d98996fb4960ae2e92d18..c79dcc497e136eb8012c2dc15e4477512fa94e1e 100644 (file)
@@ -953,6 +953,7 @@ static int configure_channels(struct c8sectpfei *fei)
                if (ret) {
                        dev_err(fei->dev,
                                "configure_memdma_and_inputblock failed\n");
+                       of_node_put(child);
                        goto err_unmap;
                }
                index++;