]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
Fix memory leak in virsh snapshot-list.
authorChris Lalancette <clalance@redhat.com>
Fri, 23 Apr 2010 15:59:39 +0000 (11:59 -0400)
committerChris Lalancette <clalance@redhat.com>
Fri, 23 Apr 2010 18:23:27 +0000 (14:23 -0400)
We were forgetting to release the memory allocated by
virDomainSnapshotListNames.  Free the memory properly.

Signed-off-by: Chris Lalancette <clalance@redhat.com>
tools/virsh.c

index b2a1538b80016cb8f5d9355d833c557367bf43c4..5bcf0ede9aeb68976abc79e79b349f32456b1341 100644 (file)
@@ -8360,7 +8360,7 @@ cmdSnapshotList(vshControl *ctl, const vshCmd *cmd)
     int ret = FALSE;
     int numsnaps;
     char **names = NULL;
-    int actual;
+    int actual = 0;
     int i;
     xmlDocPtr xml = NULL;
     xmlXPathContextPtr ctxt = NULL;
@@ -8447,6 +8447,8 @@ cleanup:
     if (xml)
         xmlFreeDoc(xml);
     VIR_FREE(doc);
+    for (i = 0; i < actual; i++)
+        VIR_FREE(names[i]);
     VIR_FREE(names);
     if (dom)
         virDomainFree(dom);