]> git.ipfire.org Git - thirdparty/knot-resolver.git/commitdiff
daemon/worker: decrease log level of uv_udp_connect() failure docs-develop-log-7sjd37/deployments/5748
authorVladimír Čunát <vladimir.cunat@nic.cz>
Tue, 19 Nov 2024 07:42:44 +0000 (08:42 +0100)
committerVladimír Čunát <vladimir.cunat@nic.cz>
Mon, 25 Nov 2024 12:45:45 +0000 (13:45 +0100)
In particular, ENETUNREACH happens on systems without IPv6,
and it doesn't make much sense to log about that by default:
  [io    ] Failed to establish udp connection: address not available

Introduced in 82e1d596 (v6.0.9).

Also log the IP address.

NEWS
daemon/worker.c

diff --git a/NEWS b/NEWS
index 6e66c59047b71f0e49bceacde472114b92473207..6b86a803f8dea737dd11a266ab906f4bf3cf8916 100644 (file)
--- a/NEWS
+++ b/NEWS
@@ -1,3 +1,11 @@
+Knot Resolver 6.0.10 (202y-mm-dd)
+================================
+
+Improvements
+------------
+- avoid multiple log lines when IPv6 isn't available (!1633)
+
+
 Knot Resolver 6.0.9 (2024-11-11)
 ================================
 
index c14f927f8a934d30c4ddf10d1a00a82bba87142a..d517dd6c28a4bf51407033590544393a60f50850 100644 (file)
@@ -838,8 +838,10 @@ static int transmit(struct qr_task *task)
                do {
                        ret = uv_udp_connect(udp, out_comm.comm_addr);
                } while (ret == UV_EADDRINUSE && --connect_tries > 0);
-               if (ret < 0)
-                       kr_log_error(IO, "Failed to establish udp connection: %s\n", uv_strerror(ret));
+               if (ret < 0) {
+                       kr_log_info(IO, "Failed to establish udp connection to %s: %s\n",
+                                       kr_straddr(out_comm.comm_addr), uv_strerror(ret));
+               }
        }
        ret = qr_task_send(task, session, &out_comm, task->pktbuf);
        if (ret) {