]> git.ipfire.org Git - thirdparty/samba.git/commitdiff
s3/libads: clang: Fix Value stored to 'canon_princ' is never read
authorNoel Power <noel.power@suse.com>
Thu, 8 Aug 2019 14:06:28 +0000 (15:06 +0100)
committerGary Lockyer <gary@samba.org>
Wed, 28 Aug 2019 01:47:40 +0000 (01:47 +0000)
Fixes:

source3/libads/kerberos.c:192:2: warning: Value stored to 'canon_princ' is never read <--[clang]
        canon_princ = me;
        ^             ~~
1 warning generated.

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
source3/libads/kerberos.c

index 721c3c2a92942b16ca988a18770b35853cf89140..9fbe7dd0f0714b71ec9e5f2d61eda806fc2f39bf 100644 (file)
@@ -189,9 +189,10 @@ int kerberos_kinit_password_ext(const char *principal,
                goto out;
        }
 
-       canon_princ = me;
 #ifndef SAMBA4_USES_HEIMDAL /* MIT */
        canon_princ = my_creds.client;
+#else
+       canon_princ = me;
 #endif /* MIT */
 
        if ((code = krb5_cc_initialize(ctx, cc, canon_princ))) {