res_pjsip: Strip spaces from items parsed from comma-separated lists

Configurations like "aors = a, b, c" were either ignoring everything after "a"
or trying to look up " b".  Same for mailboxes,  ciphers, contacts and a few
others.

To fix, all the strsep(&copy, ",") calls have been wrapped in ast_strip.  To
facilitate this, ast_strip, ast_skip_blanks and ast_skip_nonblanks were
updated to handle null pointers.

In some cases, an ast_strlen_zero() test was added to skip consecutive commas.

There was also an attempt to ast_free an ast_strdupa'd string in
ast_sip_for_each_aor which was causing a SEGV.  I removed it.

Although this issue was reported for realtime, the issue was in the res_pjsip
modules so all config mechanisms were affected.

ASTERISK-25829 #close
Reported-by: Mateusz Kowalski
Change-Id: I0b22a2cf22a7c1c50d4ecacbfa540155bec0e7a2

diff --git a/channels/pjsip/dialplan_functions.c b/channels/pjsip/dialplan_functions.c
index eb6def60f1cf5b7ac83949aa5e775e1f79959ebc..b5665039a0066f417e31043ff9c3c2a234fad538 100644 (file)
--- a/channels/pjsip/dialplan_functions.c
+++ b/channels/pjsip/dialplan_functions.c
@@ -819,7 +819,7 @@ int pjsip_acf_dial_contacts_read(struct ast_channel *chan, const char *cmd, char
                return -1;
        }
 
-       while ((aor_name = strsep(&rest, ","))) {
+       while ((aor_name = ast_strip(strsep(&rest, ",")))) {
                RAII_VAR(struct ast_sip_aor *, aor, ast_sip_location_retrieve_aor(aor_name), ao2_cleanup);
                RAII_VAR(struct ao2_container *, contacts, NULL, ao2_cleanup);
                struct ao2_iterator it_contacts;

diff --git a/include/asterisk/strings.h b/include/asterisk/strings.h
index af5ae6c55655900885066f47983c2e169ee720cb..3701b5305939364826acde1b58cc0ae9760c90a6 100644 (file)
--- a/include/asterisk/strings.h
+++ b/include/asterisk/strings.h
@@ -145,8 +145,12 @@ static int force_inline attribute_pure ast_ends_with(const char *str, const char
 AST_INLINE_API(
 char * attribute_pure ast_skip_blanks(const char *str),
 {
-       while (*str && ((unsigned char) *str) < 33)
-               str++;
+       if (str) {
+               while (*str && ((unsigned char) *str) < 33) {
+                       str++;
+               }
+       }
+
        return (char *) str;
 }
 )
@@ -184,8 +188,12 @@ char *ast_trim_blanks(char *str),
 AST_INLINE_API(
 char * attribute_pure ast_skip_nonblanks(const char *str),
 {
-       while (*str && ((unsigned char) *str) > 32)
-               str++;
+       if (str) {
+               while (*str && ((unsigned char) *str) > 32) {
+                       str++;
+               }
+       }
+
        return (char *) str;
 }
 )

diff --git a/res/res_pjsip/config_transport.c b/res/res_pjsip/config_transport.c
index 61a979c88579a967b3cbe2681944358655097938..db579bf2f628f7701db0349be65eda893af77597 100644 (file)
--- a/res/res_pjsip/config_transport.c
+++ b/res/res_pjsip/config_transport.c
@@ -985,8 +985,7 @@ static int transport_tls_cipher_handler(const struct aco_option *opt, struct ast
        }
 
        parse = ast_strdupa(S_OR(var->value, ""));
-       while ((name = strsep(&parse, ","))) {
-               name = ast_strip(name);
+       while ((name = ast_strip(strsep(&parse, ",")))) {
                if (ast_strlen_zero(name)) {
                        continue;
                }

diff --git a/res/res_pjsip/location.c b/res/res_pjsip/location.c
index 2908f6f70c85539607f94294e780027fb40af0cc..4284f35f15c89a635c052a38de9a1d53be3de01e 100644 (file)
--- a/res/res_pjsip/location.c
+++ b/res/res_pjsip/location.c
@@ -210,7 +210,7 @@ void ast_sip_location_retrieve_contact_and_aor_from_list(const char *aor_list, s
        *aor = NULL;
        *contact = NULL;
 
-       while ((aor_name = strsep(&rest, ","))) {
+       while ((aor_name = ast_strip(strsep(&rest, ",")))) {
                *aor = ast_sip_location_retrieve_aor(aor_name);
 
                if (!(*aor)) {
@@ -382,12 +382,16 @@ static int permanent_uri_handler(const struct aco_option *opt, struct ast_variab
        }
 
        contacts = ast_strdupa(var->value);
-       while ((contact_uri = strsep(&contacts, ","))) {
+       while ((contact_uri = ast_strip(strsep(&contacts, ",")))) {
                struct ast_sip_contact *contact;
                struct ast_sip_contact_status *status;
                char hash[33];
                char contact_id[strlen(aor_id) + sizeof(hash) + 2];
 
+               if (ast_strlen_zero(contact_uri)) {
+                       continue;
+               }
+
                if (!aor->permanent_contacts) {
                        aor->permanent_contacts = ao2_container_alloc_list(AO2_ALLOC_OPT_LOCK_NOLOCK,
                                AO2_CONTAINER_ALLOC_OPT_DUPS_REJECT, permanent_uri_sort_fn, NULL);
@@ -447,7 +451,7 @@ int ast_sip_for_each_aor(const char *aors, ao2_callback_fn on_aor, void *arg)
        }
 
        copy = ast_strdupa(aors);
-       while ((name = strsep(&copy, ","))) {
+       while ((name = ast_strip(strsep(&copy, ",")))) {
                RAII_VAR(struct ast_sip_aor *, aor,
                         ast_sip_location_retrieve_aor(name), ao2_cleanup);
 
@@ -459,7 +463,6 @@ int ast_sip_for_each_aor(const char *aors, ao2_callback_fn on_aor, void *arg)
                        return -1;
                }
        }
-       ast_free(copy);
        return 0;
 }
 

diff --git a/res/res_pjsip/pjsip_configuration.c b/res/res_pjsip/pjsip_configuration.c
index 1eed9284ba61cb68cf3e4de6b0978be3105ad123..ebd621261beaf18eef1c4f3057abb064fccac985 100644 (file)
--- a/res/res_pjsip/pjsip_configuration.c
+++ b/res/res_pjsip/pjsip_configuration.c
@@ -413,7 +413,7 @@ int ast_sip_auth_vector_init(struct ast_sip_auth_vector *auths, const char *valu
                return -1;
        }
 
-       while ((val = strsep(&auth_names, ","))) {
+       while ((val = ast_strip(strsep(&auth_names, ",")))) {
                if (ast_strlen_zero(val)) {
                        continue;
                }
@@ -480,7 +480,11 @@ static int ident_handler(const struct aco_option *opt, struct ast_variable *var,
        char *idents = ast_strdupa(var->value);
        char *val;
 
-       while ((val = strsep(&idents, ","))) {
+       while ((val = ast_strip(strsep(&idents, ",")))) {
+               if (ast_strlen_zero(val)) {
+                       continue;
+               }
+
                if (!strcasecmp(val, "username")) {
                        endpoint->ident_method |= AST_SIP_ENDPOINT_IDENTIFY_BY_USERNAME;
                } else {

diff --git a/res/res_pjsip/pjsip_options.c b/res/res_pjsip/pjsip_options.c
index f3c073704a6c755a9fd9f2e5e677b4155534e46e..de551dc0acea56c47960f2f23f79ca0987f454ee 100644 (file)
--- a/res/res_pjsip/pjsip_options.c
+++ b/res/res_pjsip/pjsip_options.c
@@ -281,7 +281,7 @@ static int on_endpoint(void *obj, void *arg, int flags)
        }
 
        aors = ast_strdupa(endpoint->aors);
-       while ((aor_name = strsep(&aors, ","))) {
+       while ((aor_name = ast_strip(strsep(&aors, ",")))) {
                struct ast_sip_aor *aor;
                struct ao2_container *contacts;
 
@@ -806,7 +806,7 @@ static int cli_qualify_contacts(void *data)
        }
 
        aors = ast_strdupa(endpoint->aors);
-       while ((aor_name = strsep(&aors, ","))) {
+       while ((aor_name = ast_strip(strsep(&aors, ",")))) {
                struct ast_sip_aor *aor;
                struct ao2_container *contacts;
 
@@ -910,7 +910,7 @@ static int ami_sip_qualify(struct mansession *s, const struct message *m)
        }
 
        aors = ast_strdupa(endpoint->aors);
-       while ((aor_name = strsep(&aors, ","))) {
+       while ((aor_name = ast_strip(strsep(&aors, ",")))) {
                struct ast_sip_aor *aor;
                struct ao2_container *contacts;
 
@@ -1098,7 +1098,7 @@ static int qualify_and_schedule_all_cb(void *obj, void *arg, int flags)
        }
 
        aors = ast_strdupa(endpoint->aors);
-       while ((aor_name = strsep(&aors, ","))) {
+       while ((aor_name = ast_strip(strsep(&aors, ",")))) {
                struct ast_sip_aor *aor;
                struct ao2_container *contacts;
 

diff --git a/res/res_pjsip_endpoint_identifier_ip.c b/res/res_pjsip_endpoint_identifier_ip.c
index 11559adf5f036e104f52de12a96447b171bc5ab2..7f4858af09d63fd75ac98b7b2e99b47ae4ab7b3a 100644 (file)
--- a/res/res_pjsip_endpoint_identifier_ip.c
+++ b/res/res_pjsip_endpoint_identifier_ip.c
@@ -164,11 +164,15 @@ static int ip_identify_match_handler(const struct aco_option *opt, struct ast_va
                return 0;
        }
 
-       while ((current_string = strsep(&input_string, ","))) {
+       while ((current_string = ast_strip(strsep(&input_string, ",")))) {
                struct ast_sockaddr *addrs;
                int num_addrs = 0, error = 0, i;
                char *mask = strrchr(current_string, '/');
 
+               if (ast_strlen_zero(current_string)) {
+                       continue;
+               }
+
                if (mask) {
                        identify->matches = ast_append_ha("d", current_string, identify->matches, &error);
 

diff --git a/res/res_pjsip_mwi.c b/res/res_pjsip_mwi.c
index 1bc1adf8b92430b2dffdd58d5a652cea8f5741d0..7bec75819fdd5ec62ca0337558ecc2a766f5ec8c 100644 (file)
--- a/res/res_pjsip_mwi.c
+++ b/res/res_pjsip_mwi.c
@@ -432,7 +432,7 @@ static void send_unsolicited_mwi_notify(struct mwi_subscription *sub,
        ast_debug(5, "Sending unsolicited MWI NOTIFY to endpoint %s, new messages: %d, old messages: %d\n",
                        sub->id, counter->new_msgs, counter->old_msgs);
 
-       while ((aor_name = strsep(&endpoint_aors, ","))) {
+       while ((aor_name = ast_strip(strsep(&endpoint_aors, ",")))) {
                RAII_VAR(struct ast_sip_aor *, aor, ast_sip_location_retrieve_aor(aor_name), ao2_cleanup);
                RAII_VAR(struct ao2_container *, contacts, NULL, ao2_cleanup);
                struct unsolicited_mwi_data mwi_data = {
@@ -598,7 +598,11 @@ static int mwi_validate_for_aor(void *obj, void *arg, int flags)
        }
 
        mailboxes = ast_strdupa(aor->mailboxes);
-       while ((mailbox = strsep(&mailboxes, ","))) {
+       while ((mailbox = ast_strip(strsep(&mailboxes, ",")))) {
+               if (ast_strlen_zero(mailbox)) {
+                       continue;
+               }
+
                if (endpoint_receives_unsolicited_mwi_for_mailbox(endpoint, mailbox)) {
                        ast_debug(1, "Endpoint '%s' already configured for unsolicited MWI for mailbox '%s'. "
                                        "Denying MWI subscription to %s\n", ast_sorcery_object_get_id(endpoint), mailbox,
@@ -622,9 +626,13 @@ static int mwi_on_aor(void *obj, void *arg, int flags)
        }
 
        mailboxes = ast_strdupa(aor->mailboxes);
-       while ((mailbox = strsep(&mailboxes, ","))) {
+       while ((mailbox = ast_strip(strsep(&mailboxes, ",")))) {
                struct mwi_stasis_subscription *mwi_stasis_sub;
 
+               if (ast_strlen_zero(mailbox)) {
+                       continue;
+               }
+
                mwi_stasis_sub = mwi_stasis_subscription_alloc(mailbox, sub);
                if (!mwi_stasis_sub) {
                        continue;
@@ -890,7 +898,7 @@ static int create_mwi_subscriptions_for_endpoint(void *obj, void *arg, int flags
 
        endpoint_aors = ast_strdupa(endpoint->aors);
 
-       while ((aor_name = strsep(&endpoint_aors, ","))) {
+       while ((aor_name = ast_strip(strsep(&endpoint_aors, ",")))) {
                RAII_VAR(struct ast_sip_aor *, aor, ast_sip_location_retrieve_aor(aor_name), ao2_cleanup);
 
                if (!aor) {
@@ -921,11 +929,15 @@ static int create_mwi_subscriptions_for_endpoint(void *obj, void *arg, int flags
        }
 
        mailboxes = ast_strdupa(endpoint->subscription.mwi.mailboxes);
-       while ((mailbox = strsep(&mailboxes, ","))) {
-               struct mwi_subscription *sub = aggregate_sub ?:
-                       mwi_subscription_alloc(endpoint, 0, NULL);
+       while ((mailbox = ast_strip(strsep(&mailboxes, ",")))) {
+               struct mwi_subscription *sub;
                struct mwi_stasis_subscription *mwi_stasis_sub;
 
+               if (ast_strlen_zero(mailbox)) {
+                       continue;
+               }
+
+               sub = aggregate_sub ?: mwi_subscription_alloc(endpoint, 0, NULL);
                mwi_stasis_sub = mwi_stasis_subscription_alloc(mailbox, sub);
                if (mwi_stasis_sub) {
                        ao2_link(sub->stasis_subs, mwi_stasis_sub);

diff --git a/res/res_pjsip_notify.c b/res/res_pjsip_notify.c
index 96367cf61ccf0d3722efeeb436fdc4cc1042e0f3..8258b3857f83af636102f3aa4cc010e898eda6a0 100644 (file)
--- a/res/res_pjsip_notify.c
+++ b/res/res_pjsip_notify.c
@@ -615,7 +615,7 @@ static int notify_endpoint(void *obj)
 
        aors = ast_strdupa(data->endpoint->aors);
 
-       while ((aor_name = strsep(&aors, ","))) {
+       while ((aor_name = ast_strip(strsep(&aors, ",")))) {
                RAII_VAR(struct ast_sip_aor *, aor,
                         ast_sip_location_retrieve_aor(aor_name), ao2_cleanup);
                RAII_VAR(struct ao2_container *, contacts, NULL, ao2_cleanup);

diff --git a/res/res_pjsip_path.c b/res/res_pjsip_path.c
index d0ee5a49a5353abab0d51887805aa9b4855ab12c..47d6a790661f441583194d890f784cde7d6cf4dd 100644 (file)
--- a/res/res_pjsip_path.c
+++ b/res/res_pjsip_path.c
@@ -53,9 +53,13 @@ static struct ast_sip_aor *find_aor(struct ast_sip_endpoint *endpoint, pjsip_uri
        configured_aors = ast_strdupa(endpoint->aors);
 
        /* Iterate the configured AORs to see if the user or the user+domain match */
-       while ((aor_name = strsep(&configured_aors, ","))) {
+       while ((aor_name = ast_strip(strsep(&configured_aors, ",")))) {
                struct ast_sip_domain_alias *alias = NULL;
 
+               if (ast_strlen_zero(aor_name)) {
+                       continue;
+               }
+
                if (!pj_strcmp2(&sip_uri->user, aor_name)) {
                        break;
                }

diff --git a/res/res_pjsip_pubsub.c b/res/res_pjsip_pubsub.c
index 643ed850fc30c35d6b7dbae24b528d2fdd1cfb08..d859b760ae7d633281cd47ea6e46169bdb979322 100644 (file)
--- a/res/res_pjsip_pubsub.c
+++ b/res/res_pjsip_pubsub.c
@@ -3654,7 +3654,11 @@ static int list_item_handler(const struct aco_option *opt,
        char *items = ast_strdupa(var->value);
        char *item;
 
-       while ((item = strsep(&items, ","))) {
+       while ((item = ast_strip(strsep(&items, ",")))) {
+               if (ast_strlen_zero(item)) {
+                       continue;
+               }
+
                if (item_in_vector(list, item)) {
                        ast_log(LOG_WARNING, "Ignoring duplicated list item '%s'\n", item);
                        continue;

diff --git a/res/res_pjsip_registrar.c b/res/res_pjsip_registrar.c
index b0f8d66f3d703c0f738a800c5979bf7a2b98b91a..fb2b9dabac71aacd100a15308916604ebf5594b9 100644 (file)
--- a/res/res_pjsip_registrar.c
+++ b/res/res_pjsip_registrar.c
@@ -651,9 +651,13 @@ static pj_bool_t registrar_on_rx_request(struct pjsip_rx_data *rdata)
        configured_aors = ast_strdupa(endpoint->aors);
 
        /* Iterate the configured AORs to see if the user or the user+domain match */
-       while ((aor_name = strsep(&configured_aors, ","))) {
+       while ((aor_name = ast_strip(strsep(&configured_aors, ",")))) {
                struct ast_sip_domain_alias *alias = NULL;
 
+               if (ast_strlen_zero(aor_name)) {
+                       continue;
+               }
+
                if (!pj_strcmp2(&uri->user, aor_name)) {
                        break;
                }