Bluetooth: qca: Fix error code in qca_read_fw_build_info()

[ Upstream commit a189f0ee6685457528db7a36ded3085e5d13ddc3 ]

Return -ENOMEM on allocation failure.  Don't return success.

Fixes: cda0d6a198e2 ("Bluetooth: qca: fix info leak when fetching fw build id")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: Johan Hovold <johan+linaro@kernel.org>
Signed-off-by: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>

diff --git a/drivers/bluetooth/btqca.c b/drivers/bluetooth/btqca.c
index 638074992c829b71b5f6682a39b850c77757757a..35fb26cbf229411130d93e68a757c6baa8bee2d8 100644 (file)
--- a/drivers/bluetooth/btqca.c
+++ b/drivers/bluetooth/btqca.c
@@ -148,8 +148,10 @@ static int qca_read_fw_build_info(struct hci_dev *hdev)
        }
 
        build_label = kstrndup(&edl->data[1], build_lbl_len, GFP_KERNEL);
-       if (!build_label)
+       if (!build_label) {
+               err = -ENOMEM;
                goto out;
+       }
 
        hci_set_fw_info(hdev, "%s", build_label);