]> git.ipfire.org Git - thirdparty/dovecot/core.git/commitdiff
lib-http: Remove unnecessary NULL check
authorTimo Sirainen <timo.sirainen@open-xchange.com>
Tue, 31 Jan 2023 16:12:53 +0000 (18:12 +0200)
committerTimo Sirainen <timo.sirainen@open-xchange.com>
Tue, 31 Jan 2023 16:12:53 +0000 (18:12 +0200)
This is confusing static analyzers.

Broken by 987fab8f4e143ab851c3318c8614e81bb0f2b360

src/lib-http/http-client-request.c

index 7e578a618684573e576e53e64aec4b2ce0ded9b0..81a78bcc5426fde10b1bf7ada7cabb93bccb42ef 100644 (file)
@@ -1073,8 +1073,7 @@ http_client_request_finish_payload_out(struct http_client_request *req)
                o_stream_unref(&req->payload_output);
                req->payload_output = NULL;
        }
-       if (conn->conn.output != NULL &&
-           o_stream_get_buffer_used_size(conn->conn.output) > 0) {
+       if (o_stream_get_buffer_used_size(conn->conn.output) > 0) {
                e_debug(req->event,
                        "Not quite finished sending request");
                conn->output_locked = TRUE;