drm/amd/display: Fix mismatch type comparison

[ Upstream commit 26873260d394b1e33cdd720154aedf0af95327f9 ]

The mismatch type comparison/assignment may cause data loss. Since the
values are always non-negative, it is safe to use unsigned variables to
resolve the mismatch.

Signed-off-by: Navid Assadian <navid.assadian@amd.com>
Reviewed-by: Joshua Aberback <joshua.aberback@amd.com>
Tested-by: Daniel Wheeler <daniel.wheeler@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>

diff --git a/drivers/gpu/drm/amd/display/dc/spl/dc_spl.c b/drivers/gpu/drm/amd/display/dc/spl/dc_spl.c
index 18b423bd302a7d861bc9e1820a37a1fd64d7fce4..22602f088553d5440e75135c3bcfb6520fc1107f 100644 (file)
--- a/drivers/gpu/drm/amd/display/dc/spl/dc_spl.c
+++ b/drivers/gpu/drm/amd/display/dc/spl/dc_spl.c
@@ -963,8 +963,8 @@ static bool spl_get_optimal_number_of_taps(
          bool *enable_isharp)
 {
        int num_part_y, num_part_c;
-       int max_taps_y, max_taps_c;
-       int min_taps_y, min_taps_c;
+       unsigned int max_taps_y, max_taps_c;
+       unsigned int min_taps_y, min_taps_c;
        enum lb_memory_config lb_config;
        bool skip_easf = false;
        bool is_subsampled = spl_is_subsampled_format(spl_in->basic_in.format);

diff --git a/drivers/gpu/drm/amd/display/dc/spl/dc_spl_types.h b/drivers/gpu/drm/amd/display/dc/spl/dc_spl_types.h
index 467af9dd90ded18396cf3dc9a0b7e9d6e3c654be..5d139cf51e89b5652d6c926f331ebcf97cab6615 100644 (file)
--- a/drivers/gpu/drm/amd/display/dc/spl/dc_spl_types.h
+++ b/drivers/gpu/drm/amd/display/dc/spl/dc_spl_types.h
@@ -484,7 +484,7 @@ struct spl_sharpness_range {
 };
 struct adaptive_sharpness {
        bool enable;
-       int sharpness_level;
+       unsigned int sharpness_level;
        struct spl_sharpness_range sharpness_range;
 };
 enum linear_light_scaling      {       // convert it in translation logic