]> git.ipfire.org Git - thirdparty/dhcpcd.git/commitdiff
Fix some logic
authorRoy Marples <roy@marples.name>
Wed, 10 Jun 2020 13:42:08 +0000 (14:42 +0100)
committerRoy Marples <roy@marples.name>
Wed, 10 Jun 2020 13:42:08 +0000 (14:42 +0100)
src/privsep-control.c

index ba8dff0945b6dba9742892ed96f12c6a8e68de11..619171f8fde562c707c04eba9a7a3d08c261071c 100644 (file)
@@ -255,7 +255,9 @@ ps_ctl_start(struct dhcpcd_ctx *ctx)
            ps_ctl_startcb, ps_ctl_signalcb,
            PSF_DROPPRIVS);
 
-       if (pid != 0) {
+       if (pid == -1)
+               return -1;
+       else if (pid != 0) {
                ctx->ps_control_data_fd = data_fd[1];
                close(data_fd[0]);
                ctx->ps_control = control_new(ctx,
@@ -264,8 +266,7 @@ ps_ctl_start(struct dhcpcd_ctx *ctx)
                        return -1;
                close(listen_fd[0]);
                return pid;
-       } else if (pid == -1)
-               return -1;
+       }
 
        ctx->ps_control_data_fd = data_fd[0];
        close(data_fd[1]);