]> git.ipfire.org Git - thirdparty/xfsprogs-dev.git/commitdiff
xfs: fix variable state usage
authorDarrick J. Wong <djwong@kernel.org>
Wed, 6 Jul 2022 18:48:57 +0000 (13:48 -0500)
committerEric Sandeen <sandeen@redhat.com>
Wed, 6 Jul 2022 18:48:57 +0000 (13:48 -0500)
Source kernel commit: 10930b254d5be1cb4350fb7a456ccd5ea7e3cbd9

The variable @args is fed to a tracepoint, and that's the only place
it's used.  This is fine for the kernel, but for userspace, tracepoints
are #define'd out of existence, which results in this warning on gcc
11.2:

xfs_attr.c: In function ‘xfs_attr_node_try_addname’:
xfs_attr.c:1440:42: warning: unused variable ‘args’ [-Wunused-variable]
1440 |         struct xfs_da_args              *args = attr->xattri_da_args;
|                                          ^~~~

Clean this up.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
Reviewed-by: Dave Chinner <dchinner@redhat.com>
Reviewed-by: Allison Henderson <allison.henderson@oracle.com>
Signed-off-by: Eric Sandeen <sandeen@sandeen.net>
libxfs/xfs_attr.c

index d2e28a27a4bb7d15340225c331891f2e0c5346b5..dba528e67d1bd9d8a653712b7e38af4ca4ffbf3e 100644 (file)
@@ -1439,12 +1439,11 @@ static int
 xfs_attr_node_try_addname(
        struct xfs_attr_intent          *attr)
 {
-       struct xfs_da_args              *args = attr->xattri_da_args;
        struct xfs_da_state             *state = attr->xattri_da_state;
        struct xfs_da_state_blk         *blk;
        int                             error;
 
-       trace_xfs_attr_node_addname(args);
+       trace_xfs_attr_node_addname(state->args);
 
        blk = &state->path.blk[state->path.active-1];
        ASSERT(blk->magic == XFS_ATTR_LEAF_MAGIC);