Bug 347453: Checksetup needs Perl-LDAP for Net::LDAP module on Windows

Patch By Max Kanat-Alexander <mkanat@bugzilla.org> (module owner) a=justdave

diff --git a/Bugzilla/Install/Requirements.pm b/Bugzilla/Install/Requirements.pm
index 22c581eae79c853cad89cb236c67c2167c27fdff..06c8b557ba7c90d9cf4c0dc46bf8f4e88a8d73b0 100644 (file)
--- a/Bugzilla/Install/Requirements.pm
+++ b/Bugzilla/Install/Requirements.pm
@@ -158,6 +158,7 @@ use constant WIN32_MODULE_NAMES => {
     'GD::Graph'         => 'GDGraph',
     'GD::Text::Align'   => 'GDTextUtil',
     'Mail::Mailer'      => 'MailTools',
+    'Net::LDAP'         => 'perl-ldap',
     # We provide Template 2.14 or lower for Win32, so it still includes
     # the GD plugin.
     'Template::Plugin::GD' => 'Template-Toolkit',
@@ -498,7 +499,7 @@ sub vers_cmp {
 
 sub install_command {
     my $module = shift;
-    if ($^O =~ /MSWin32/i) {
+    if (ON_WINDOWS) {
         return "ppm install " . WIN32_MODULE_NAMES->{$module} if
             WIN32_MODULE_NAMES->{$module};
         $module =~ s/::/-/g;