]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
ASoC: renesas: rz-ssi: Simplify the logic in rz_ssi_stream_is_play()
authorClaudiu Beznea <claudiu.beznea.uj@bp.renesas.com>
Mon, 19 Jan 2026 19:52:49 +0000 (21:52 +0200)
committerMark Brown <broonie@kernel.org>
Tue, 20 Jan 2026 12:14:28 +0000 (12:14 +0000)
The code in rz_ssi_stream_is_play() checks whether substream->stream is
different from SNDRV_PCM_STREAM_PLAYBACK and returns the capture
struct rz_ssi_stream in that case. The logic is easier to follow if
substream->stream is compared directly against SNDRV_PCM_STREAM_CAPTURE
and return the capture struct rz_ssi_stream.

Use the conditional operator to simplify the code.

Signed-off-by: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>
Link: https://patch.msgid.link/20260119195252.3362486-2-claudiu.beznea.uj@bp.renesas.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/renesas/rz-ssi.c

index f4dc2f68deadacca03eb9d9993567d7ded56759e..f144cbc89fad66845e61a1bf61097815f1605357 100644 (file)
@@ -178,12 +178,7 @@ static inline bool rz_ssi_stream_is_play(struct snd_pcm_substream *substream)
 static inline struct rz_ssi_stream *
 rz_ssi_stream_get(struct rz_ssi_priv *ssi, struct snd_pcm_substream *substream)
 {
-       struct rz_ssi_stream *stream = &ssi->playback;
-
-       if (substream->stream != SNDRV_PCM_STREAM_PLAYBACK)
-               stream = &ssi->capture;
-
-       return stream;
+       return (ssi->playback.substream == substream) ? &ssi->playback : &ssi->capture;
 }
 
 static inline bool rz_ssi_is_dma_enabled(struct rz_ssi_priv *ssi)