]> git.ipfire.org Git - thirdparty/sqlalchemy/sqlalchemy.git/commitdiff
comment out the rollback on after test since pg8000 can deadlock on this (and its...
authorMike Bayer <mike_mp@zzzcomputing.com>
Sat, 30 Apr 2011 19:38:27 +0000 (15:38 -0400)
committerMike Bayer <mike_mp@zzzcomputing.com>
Sat, 30 Apr 2011 19:38:27 +0000 (15:38 -0400)
but then what about the pypy jython team.  ho hum.

test/lib/engines.py

index 0c980c376fb2b21c12f5a5fa2bac94611c784c79..6202c0a3df2bddd8b27fcaa1b60ddba04b7f1248 100644 (file)
@@ -1,7 +1,7 @@
 import sys, types, weakref
 from collections import deque
 from test.bootstrap import config
-from test.lib.util import decorator
+from test.lib.util import decorator, gc_collect
 from sqlalchemy.util import callable
 from sqlalchemy import event, pool
 from sqlalchemy.engine import base as engine_base
@@ -42,8 +42,13 @@ class ConnectionKiller(object):
                 self._safe(rec._close)
 
     def _after_test_ctx(self):
-        for conn in self.conns:
-            self._safe(conn.rollback)
+        pass
+        # this can cause a deadlock with pg8000 - pg8000 acquires
+        # prepared statment lock inside of rollback() - if async gc
+        # is collecting in finalize_fairy, deadlock.
+        # not sure if this should be if pypy/jython only
+        #for conn in self.conns:
+        #    self._safe(conn.rollback)
 
     def _stop_test_ctx(self):
         self.close_all()