]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
xprtrdma: Fix regbuf data not freed in rpcrdma_req_create()
authorZhang Xiaoxu <zhangxiaoxu5@huawei.com>
Sun, 20 Nov 2022 07:34:29 +0000 (15:34 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 31 Dec 2022 12:26:09 +0000 (13:26 +0100)
[ Upstream commit 9181f40fb2952fd59ecb75e7158620c9c669eee3 ]

If rdma receive buffer allocate failed, should call rpcrdma_regbuf_free()
to free the send buffer, otherwise, the buffer data will be leaked.

Fixes: bb93a1ae2bf4 ("xprtrdma: Allocate req's regbufs at xprt create time")
Signed-off-by: Zhang Xiaoxu <zhangxiaoxu5@huawei.com>
Signed-off-by: Trond Myklebust <trond.myklebust@hammerspace.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
net/sunrpc/xprtrdma/verbs.c

index 2fbe9aaeec349a6c27bceb0b7c070f5b0e4363b7..efa7bcdf6b28327b4aa4bfde7488da54909490d9 100644 (file)
@@ -834,7 +834,7 @@ struct rpcrdma_req *rpcrdma_req_create(struct rpcrdma_xprt *r_xprt, size_t size,
        return req;
 
 out3:
-       kfree(req->rl_sendbuf);
+       rpcrdma_regbuf_free(req->rl_sendbuf);
 out2:
        kfree(req);
 out1: