Merged revisions 287307 via svnmerge from

https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r287307 | mnicholson | 2010-09-17 08:34:34 -0500 (Fri, 17 Sep 2010) | 5 lines

  Use ast_strdup() instead of ast_strdupa() while processing in ast_hint_state_changed().

  (related to issue #17928)
  Reported by: mdu113
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.2@287308 65c4cc65-6c06-0410-ace0-fbb531ad65f3

diff --git a/main/pbx.c b/main/pbx.c
index f5b2aeeb42a3461437d643d487b97301858e0f56..7949eb145be852db0c2006dde52ad7b4cf52f355 100644 (file)
--- a/main/pbx.c
+++ b/main/pbx.c
@@ -3866,8 +3866,10 @@ static int handle_statechange(void *datap)
 
        AST_RWLIST_TRAVERSE(&hints, hint, list) {
                struct ast_state_cb *cblist;
-               char *parse = ast_strdupa(ast_get_extension_app(hint->exten));
-               char *cur;
+               /* can't use ast_strdupa() here because we may run out of stack
+                * space while looping over a large number of large strings */
+               char *dup = ast_strdup(ast_get_extension_app(hint->exten));
+               char *cur, *parse = dup;
                int state;
 
                while ( (cur = strsep(&parse, "&")) ) {
@@ -3875,6 +3877,9 @@ static int handle_statechange(void *datap)
                                break;
                        }
                }
+
+               ast_free(dup);
+
                if (!cur) {
                        continue;
                }