util/grub-fstest: Fix resource leaks in cmd_cmp()

In the function cmd_cmp() within the while loop, srcnew and destnew are
being allocated but are never freed either before leaving scope or in
the recursive calls being made to cmd_cmp().

Fixes: CID 314032
Fixes: CID 314045
Signed-off-by: Darren Kenny <darren.kenny@oracle.com>
Reviewed-by: Daniel Kiper <daniel.kiper@oracle.com>

diff --git a/util/grub-fstest.c b/util/grub-fstest.c
index 8386564200988c74328a7f193d4e333f6e649dec..486f1dc141fdc5b62499732c7d7240dae98d2ef6 100644 (file)
--- a/util/grub-fstest.c
+++ b/util/grub-fstest.c
@@ -300,9 +300,15 @@ cmd_cmp (char *src, char *dest)
          strcpy (ptr, entry->d_name);
 
          if (grub_util_is_special_file (destnew))
-           continue;
+           {
+             free (srcnew);
+             free (destnew);
+             continue;
+           }
 
          cmd_cmp (srcnew, destnew);
+         free (srcnew);
+         free (destnew);
        }
       grub_util_fd_closedir (dir);
       return;