vircgroup: extract virCgroupV1SetMemory

Reviewed-by: Fabiano Fidêncio <fidencio@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
Signed-off-by: Pavel Hrdina <phrdina@redhat.com>

diff --git a/src/util/vircgroup.c b/src/util/vircgroup.c
index 01d5cd579987190560529158818543da1fc490a1..19c82b67bc693d5dc9b2c6ff649821a2bf7372d0 100644 (file)
--- a/src/util/vircgroup.c
+++ b/src/util/vircgroup.c
@@ -1589,25 +1589,7 @@ virCgroupGetMemoryUnlimitedKB(void)
 int
 virCgroupSetMemory(virCgroupPtr group, unsigned long long kb)
 {
-    unsigned long long maxkb = VIR_DOMAIN_MEMORY_PARAM_UNLIMITED;
-
-    if (kb > maxkb) {
-        virReportError(VIR_ERR_INVALID_ARG,
-                       _("Memory '%llu' must be less than %llu"),
-                       kb, maxkb);
-        return -1;
-    }
-
-    if (kb == maxkb)
-        return virCgroupSetValueI64(group,
-                                    VIR_CGROUP_CONTROLLER_MEMORY,
-                                    "memory.limit_in_bytes",
-                                    -1);
-    else
-        return virCgroupSetValueU64(group,
-                                    VIR_CGROUP_CONTROLLER_MEMORY,
-                                    "memory.limit_in_bytes",
-                                    kb << 10);
+    VIR_CGROUP_BACKEND_CALL(group, setMemory, -1, kb);
 }
 
 

diff --git a/src/util/vircgroupbackend.h b/src/util/vircgroupbackend.h
index 67e795a2b7417de30846c0ae4adf8588381e75f8..e1f75c5c315f150779772ec251ca6a0db348110f 100644 (file)
--- a/src/util/vircgroupbackend.h
+++ b/src/util/vircgroupbackend.h
@@ -210,6 +210,10 @@ typedef int
                                      const char *path,
                                      unsigned long long *wbps);
 
+typedef int
+(*virCgroupSetMemoryCB)(virCgroupPtr group,
+                        unsigned long long kb);
+
 struct _virCgroupBackend {
     virCgroupBackendType type;
 
@@ -248,6 +252,8 @@ struct _virCgroupBackend {
     virCgroupGetBlkioDeviceReadBpsCB getBlkioDeviceReadBps;
     virCgroupSetBlkioDeviceWriteBpsCB setBlkioDeviceWriteBps;
     virCgroupGetBlkioDeviceWriteBpsCB getBlkioDeviceWriteBps;
+
+    virCgroupSetMemoryCB setMemory;
 };
 typedef struct _virCgroupBackend virCgroupBackend;
 typedef virCgroupBackend *virCgroupBackendPtr;

diff --git a/src/util/vircgroupv1.c b/src/util/vircgroupv1.c
index 3e5c0529cb585867bc7aa365888a7cd0b24226d3..af92df3d8f6977f5c6ec5fe5a13560a1c28bb6e9 100644 (file)
--- a/src/util/vircgroupv1.c
+++ b/src/util/vircgroupv1.c
@@ -1377,6 +1377,32 @@ virCgroupV1GetBlkioDeviceWriteBps(virCgroupPtr group,
 }
 
 
+static int
+virCgroupV1SetMemory(virCgroupPtr group,
+                     unsigned long long kb)
+{
+    unsigned long long maxkb = VIR_DOMAIN_MEMORY_PARAM_UNLIMITED;
+
+    if (kb > maxkb) {
+        virReportError(VIR_ERR_INVALID_ARG,
+                       _("Memory '%llu' must be less than %llu"),
+                       kb, maxkb);
+        return -1;
+    }
+
+    if (kb == maxkb)
+        return virCgroupSetValueI64(group,
+                                    VIR_CGROUP_CONTROLLER_MEMORY,
+                                    "memory.limit_in_bytes",
+                                    -1);
+    else
+        return virCgroupSetValueU64(group,
+                                    VIR_CGROUP_CONTROLLER_MEMORY,
+                                    "memory.limit_in_bytes",
+                                    kb << 10);
+}
+
+
 virCgroupBackend virCgroupV1Backend = {
     .type = VIR_CGROUP_BACKEND_TYPE_V1,
 
@@ -1413,6 +1439,8 @@ virCgroupBackend virCgroupV1Backend = {
     .getBlkioDeviceReadBps = virCgroupV1GetBlkioDeviceReadBps,
     .setBlkioDeviceWriteBps = virCgroupV1SetBlkioDeviceWriteBps,
     .getBlkioDeviceWriteBps = virCgroupV1GetBlkioDeviceWriteBps,
+
+    .setMemory = virCgroupV1SetMemory,
 };