patch 9.1.1689: CmdlineChanged not triggered by <Del>

Problem:  CmdlineChanged not triggered by <Del>
Solution: Use STRCMP() instead of STRNCMP()
          (Shougo Matsushita)

closes: #18101

Signed-off-by: Shougo Matsushita <Shougo.Matsu@gmail.com>
Signed-off-by: Christian Brabandt <cb@256bit.org>

diff --git a/src/ex_getln.c b/src/ex_getln.c
index 289231045c3d0d76a80ba44b72b9c684a9178a90..8426f00cbddc6768cef0ba94f34748ea1e17732c 100644 (file)
--- a/src/ex_getln.c
+++ b/src/ex_getln.c
@@ -1855,7 +1855,7 @@ getcmdline_int(
 
        if (ccline.cmdbuff != NULL)
        {
-           prev_cmdbuff = vim_strnsave(ccline.cmdbuff, ccline.cmdpos);
+           prev_cmdbuff = vim_strsave(ccline.cmdbuff);
            if (prev_cmdbuff == NULL)
                goto returncmd;
        }
@@ -2622,8 +2622,8 @@ cmdline_changed:
        // Trigger CmdlineChanged autocommands.
        if (trigger_cmdlinechanged
                && (ccline.cmdpos != prev_cmdpos
-                   || (prev_cmdbuff != NULL && STRNCMP(prev_cmdbuff,
-                           ccline.cmdbuff, prev_cmdpos) != 0)))
+                   || (prev_cmdbuff != NULL &&
+                       STRCMP(prev_cmdbuff, ccline.cmdbuff) != 0)))
            trigger_cmd_autocmd(cmdline_type, EVENT_CMDLINECHANGED);
 
        // Trigger CursorMovedC autocommands.

diff --git a/src/testdir/test_autocmd.vim b/src/testdir/test_autocmd.vim
index 43605f7e1111a1b7fa44a2936d6f8b72ba409e61..2c976e82d728413dad31ffec57df4d94f55e5299 100644 (file)
--- a/src/testdir/test_autocmd.vim
+++ b/src/testdir/test_autocmd.vim
@@ -2183,6 +2183,17 @@ func Test_Cmdline()
         \ '0abc1abc2abc3',
         \ ], g:log)
 
+  " <Del> should trigger CmdlineChanged
+  let g:log = []
+  call feedkeys(":foo\<Left>\<Left>\<Del>\<Del>\<Esc>", 'xt')
+  call assert_equal([
+        \ 'f',
+        \ 'fo',
+        \ 'foo',
+        \ 'fo',
+        \ 'f',
+        \ ], g:log)
+
   unlet g:log
   au! CmdlineChanged
 

diff --git a/src/version.c b/src/version.c
index 390959c7ee5dc3e28d2d49bfcba957b455c706ad..bedb8ec0bd30f963344a3b7adab14229e3c2f12f 100644 (file)
--- a/src/version.c
+++ b/src/version.c
@@ -724,6 +724,8 @@ static char *(features[]) =
 
 static int included_patches[] =
 {   /* Add new patch number below this line */
+/**/
+    1689,
 /**/
     1688,
 /**/