Bug 488467: Verify and Login auth methods were being called in a random order, c

ausing sudo sessions to frequently not need the user to re-enter their password.
Patch by Max Kanat-Alexander <mkanat@bugzilla.org> r=LpSolit, a=LpSolit

diff --git a/Bugzilla/Auth/Login/Stack.pm b/Bugzilla/Auth/Login/Stack.pm
index ab9a93bce99bc508d122c611ccc58cbbc664b14b..a5752f22bbb23fa88eda94347475568a78b379cc 100644 (file)
--- a/Bugzilla/Auth/Login/Stack.pm
+++ b/Bugzilla/Auth/Login/Stack.pm
@@ -38,7 +38,7 @@ sub new {
     Bugzilla::Hook::process('auth-login_methods', { modules => \%methods });
 
     $self->{_stack} = [];
-    foreach my $login_method (keys %methods) {
+    foreach my $login_method (split(',', $list)) {
         my $module = $methods{$login_method};
         require $module;
         $module =~ s|/|::|g;

diff --git a/Bugzilla/Auth/Verify/Stack.pm b/Bugzilla/Auth/Verify/Stack.pm
index 0ddb9a441d61e6ff62d1ad4f08ec3d9b85f3cb00..c23b532fdf8a674d4dcde5a5433905d667d9c758 100644 (file)
--- a/Bugzilla/Auth/Verify/Stack.pm
+++ b/Bugzilla/Auth/Verify/Stack.pm
@@ -33,7 +33,7 @@ sub new {
     Bugzilla::Hook::process('auth-verify_methods', { modules => \%methods });
 
     $self->{_stack} = [];
-    foreach my $verify_method (keys %methods) {
+    foreach my $verify_method (split(',', $list)) {
         my $module = $methods{$verify_method};
         require $module;
         $module =~ s|/|::|g;