#4736 BufferRWPair.closed shouldn't try to call another property as a function

diff --git a/Lib/io.py b/Lib/io.py
index 7f938987b71243e3dae55a0539249c8bd2e5df89..320a4b9b5f23fc79da2b93e7d04d5898ddf85faa 100644 (file)
--- a/Lib/io.py
+++ b/Lib/io.py
@@ -1167,7 +1167,7 @@ class BufferedRWPair(BufferedIOBase):
 
     @property
     def closed(self):
-        return self.writer.closed()
+        return self.writer.closed
 
 
 class BufferedRandom(BufferedWriter, BufferedReader):

diff --git a/Lib/test/test_io.py b/Lib/test/test_io.py
index 8a7da60947b037a37cc56a6a409a63433873315f..967018ea453a0372641ee5f50f69292ff828c9d2 100644 (file)
--- a/Lib/test/test_io.py
+++ b/Lib/test/test_io.py
@@ -554,8 +554,9 @@ class BufferedRWPairTest(unittest.TestCase):
         r = MockRawIO(())
         w = MockRawIO()
         pair = io.BufferedRWPair(r, w)
+        self.assertFalse(pair.closed)
 
-        # XXX need implementation
+        # XXX More Tests
 
 
 class BufferedRandomTest(unittest.TestCase):

diff --git a/Misc/NEWS b/Misc/NEWS
index 775392437c06ebb1522b7132650afcdfd9915e40..026e4781d7017afe98e7c259518a4e1f287658e5 100644 (file)
--- a/Misc/NEWS
+++ b/Misc/NEWS
@@ -86,6 +86,8 @@ Core and Builtins
 Library
 -------
 
+- Issue #4736: io.BufferedRWPair's closed property now functions properly.
+
 - Issue #3954: Fix a potential SystemError in _hotshot.logreader error
   handling.