DPP: Fix DPP_RELAY_ADD_CONTROLLER command parsing

hostapd_dpp_add_controller() ended up trying to parse the IP address
without nul terminating it. This might work with some C libraries, but
not all. And anyway, this was already supposed to nul terminate the
string since a temporary copy is created of the constant string. Fix
this by adding the missed replacement of the space with nul.

Fixes: bfe3cfc382d6 ("DPP: Allow Relay connections to Controllers to be added and removed")
Signed-off-by: Jouni Malinen <quic_jouni@quicinc.com>

diff --git a/src/ap/dpp_hostapd.c b/src/ap/dpp_hostapd.c
index 7055784c4865d7c48a134c3d41bd7e7ca76eb82d..232b5fbbc1e0999406619802bb51bb7f1895b975 100644 (file)
--- a/src/ap/dpp_hostapd.c
+++ b/src/ap/dpp_hostapd.c
@@ -3427,7 +3427,7 @@ int hostapd_dpp_add_controller(struct hostapd_data *hapd, const char *cmd)
        pos = os_strchr(tmp, ' ');
        if (!pos)
                goto fail;
-       pos++;
+       *pos++ = '\0';
        if (hostapd_parse_ip_addr(tmp, &addr) < 0 ||
            hexstr2bin(pos, pkhash, SHA256_MAC_LEN) < 0)
                goto fail;