]> git.ipfire.org Git - thirdparty/suricata.git/commitdiff
detect: remove struct/union tricks from Signature
authorVictor Julien <victor@inliniac.net>
Tue, 9 Jun 2015 09:43:26 +0000 (11:43 +0200)
committerVictor Julien <victor@inliniac.net>
Tue, 9 Jun 2015 09:43:26 +0000 (11:43 +0200)
src/detect.h

index fbed549fe11994f75c04cf4f744f8c6c27fcb6aa..75a0a3436bceb4e19bed3261d4bbfea6a72901a5 100644 (file)
@@ -366,30 +366,19 @@ typedef struct SigMatchData_ {
 
 /** \brief Signature container */
 typedef struct Signature_ {
-    union {
-        struct {
-            /* coccinelle: Signature:flags:SIG_FLAG */
-            uint32_t flags;
-            AppProto alproto;
-            uint16_t dsize_low;
-        };
-        uint64_t hdr_copy1;
-    };
-    union {
-        struct {
-            uint16_t dsize_high;
-            uint16_t mpm_pattern_id_div_8;
-        };
-        uint32_t hdr_copy2;
-    };
-    union {
-        struct {
-            uint8_t mpm_pattern_id_mod_8;
-            SignatureMask mask;
-            SigIntId num; /**< signature number, internal id */
-        };
-        uint32_t hdr_copy3;
-    };
+    /* coccinelle: Signature:flags:SIG_FLAG */
+    uint32_t flags;
+
+    AppProto alproto;
+
+    uint16_t dsize_low;
+    uint16_t dsize_high;
+
+    uint16_t mpm_pattern_id_div_8;
+    uint8_t mpm_pattern_id_mod_8;
+
+    SignatureMask mask;
+    SigIntId num; /**< signature number, internal id */
 
     /** inline -- action */
     uint8_t action;