staging: rtl8723bs: rtw_hal_set_def_var is not used

The function rtw_hal_set_def_var is not used. Remove the function and
resulting dead code.

Signed-off-by: Michael Straube <straube.linux@gmail.com>
Link: https://lore.kernel.org/r/20250927182700.184174-1-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/drivers/staging/rtl8723bs/hal/hal_com.c b/drivers/staging/rtl8723bs/hal/hal_com.c
index 07e9d34236517876d2f39ede8cc143214c93446c..70b5b289f9cbca97059ca4979bfa5cfdb675dd89 100644 (file)
--- a/drivers/staging/rtl8723bs/hal/hal_com.c
+++ b/drivers/staging/rtl8723bs/hal/hal_com.c
@@ -663,71 +663,6 @@ void GetHwReg(struct adapter *adapter, u8 variable, u8 *val)
        }
 }
 
-
-
-
-u8 SetHalDefVar(
-       struct adapter *adapter, enum hal_def_variable variable, void *value
-)
-{
-       struct hal_com_data *hal_data = GET_HAL_DATA(adapter);
-       struct dm_odm_t *odm = &(hal_data->odmpriv);
-       u8 bResult = _SUCCESS;
-
-       switch (variable) {
-       case HW_DEF_ODM_DBG_FLAG:
-               ODM_CmnInfoUpdate(odm, ODM_CMNINFO_DBG_COMP, *((u64 *)value));
-               break;
-       case HW_DEF_ODM_DBG_LEVEL:
-               ODM_CmnInfoUpdate(odm, ODM_CMNINFO_DBG_LEVEL, *((u32 *)value));
-               break;
-       case HAL_DEF_DBG_DM_FUNC:
-       {
-               u8 dm_func = *((u8 *)value);
-               struct dm_priv *dm = &hal_data->dmpriv;
-
-               if (dm_func == 0) { /* disable all dynamic func */
-                       odm->SupportAbility = DYNAMIC_FUNC_DISABLE;
-               } else if (dm_func == 1) {/* disable DIG */
-                       odm->SupportAbility  &= (~DYNAMIC_BB_DIG);
-               } else if (dm_func == 2) {/* disable High power */
-                       odm->SupportAbility  &= (~DYNAMIC_BB_DYNAMIC_TXPWR);
-               } else if (dm_func == 3) {/* disable tx power tracking */
-                       odm->SupportAbility  &= (~DYNAMIC_RF_CALIBRATION);
-               } else if (dm_func == 4) {/* disable BT coexistence */
-                       dm->DMFlag &= (~DYNAMIC_FUNC_BT);
-               } else if (dm_func == 5) {/* disable antenna diversity */
-                       odm->SupportAbility  &= (~DYNAMIC_BB_ANT_DIV);
-               } else if (dm_func == 6) {/* turn on all dynamic func */
-                       if (!(odm->SupportAbility  & DYNAMIC_BB_DIG)) {
-                               struct dig_t    *pDigTable = &odm->DM_DigTable;
-                               pDigTable->CurIGValue = rtw_read8(adapter, 0xc50);
-                       }
-                       dm->DMFlag |= DYNAMIC_FUNC_BT;
-                       odm->SupportAbility = DYNAMIC_ALL_FUNC_ENABLE;
-               }
-       }
-               break;
-       case HAL_DEF_DBG_DUMP_RXPKT:
-               hal_data->bDumpRxPkt = *((u8 *)value);
-               break;
-       case HAL_DEF_DBG_DUMP_TXPKT:
-               hal_data->bDumpTxPkt = *((u8 *)value);
-               break;
-       case HAL_DEF_ANT_DETECT:
-               hal_data->AntDetection = *((u8 *)value);
-               break;
-       default:
-               netdev_dbg(adapter->pnetdev,
-                          "%s: [WARNING] HAL_DEF_VARIABLE(%d) not defined!\n",
-                          __func__, variable);
-               bResult = _FAIL;
-               break;
-       }
-
-       return bResult;
-}
-
 u8 GetHalDefVar(
        struct adapter *adapter, enum hal_def_variable variable, void *value
 )

diff --git a/drivers/staging/rtl8723bs/hal/hal_intf.c b/drivers/staging/rtl8723bs/hal/hal_intf.c
index 961b0563951d25f6f937fbfc5ef1c4735efacfc6..462553d296ffd839f57e5f32e6e42f3de953c5d7 100644 (file)
--- a/drivers/staging/rtl8723bs/hal/hal_intf.c
+++ b/drivers/staging/rtl8723bs/hal/hal_intf.c
@@ -115,11 +115,6 @@ void rtw_hal_set_hwreg_with_buf(struct adapter *padapter, u8 variable, u8 *pbuf,
        SetHwRegWithBuf8723B(padapter, variable, pbuf, len);
 }
 
-u8 rtw_hal_set_def_var(struct adapter *padapter, enum hal_def_variable eVariable, void *pValue)
-{
-       return SetHalDefVar8723BSDIO(padapter, eVariable, pValue);
-}
-
 u8 rtw_hal_get_def_var(struct adapter *padapter, enum hal_def_variable eVariable, void *pValue)
 {
        return GetHalDefVar8723BSDIO(padapter, eVariable, pValue);

diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c b/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c
index 18244adad9e0448faa9e280bc9b13e60e36adf18..57c83f332e746d130e52f37f88579deb31f973cb 100644 (file)
--- a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c
+++ b/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c
@@ -2839,22 +2839,6 @@ void GetHwReg8723B(struct adapter *padapter, u8 variable, u8 *val)
        }
 }
 
-/* Description:
- *     Change default setting of specified variable.
- */
-u8 SetHalDefVar8723B(struct adapter *padapter, enum hal_def_variable variable, void *pval)
-{
-       u8 bResult = _SUCCESS;
-
-       switch (variable) {
-       default:
-               bResult = SetHalDefVar(padapter, variable, pval);
-               break;
-       }
-
-       return bResult;
-}
-
 /* Description:
  *     Query setting of specified variable.
  */

diff --git a/drivers/staging/rtl8723bs/hal/sdio_halinit.c b/drivers/staging/rtl8723bs/hal/sdio_halinit.c
index 7fcb874d0eb3ad01ca44ce28af6a9cdd07a01563..6f1f726d1630a1a39b8616c54972ef36724b2e56 100644 (file)
--- a/drivers/staging/rtl8723bs/hal/sdio_halinit.c
+++ b/drivers/staging/rtl8723bs/hal/sdio_halinit.c
@@ -1236,12 +1236,3 @@ u8 GetHalDefVar8723BSDIO(
 
        return bResult;
 }
-
-/*  */
-/*     Description: */
-/*             Change default setting of specified variable. */
-/*  */
-u8 SetHalDefVar8723BSDIO(struct adapter *Adapter, enum hal_def_variable eVariable, void *pValue)
-{
-       return SetHalDefVar8723B(Adapter, eVariable, pValue);
-}

diff --git a/drivers/staging/rtl8723bs/include/hal_com.h b/drivers/staging/rtl8723bs/include/hal_com.h
index 7ea9ee2b397584d765ca162b0d4244f83263efb6..74d6c892c4013baac4b848b8b63188407890bcc6 100644 (file)
--- a/drivers/staging/rtl8723bs/include/hal_com.h
+++ b/drivers/staging/rtl8723bs/include/hal_com.h
@@ -138,8 +138,6 @@ void SetHwReg(struct adapter *padapter, u8 variable, u8 *val);
 void GetHwReg(struct adapter *padapter, u8 variable, u8 *val);
 void rtw_hal_check_rxfifo_full(struct adapter *adapter);
 
-u8 SetHalDefVar(struct adapter *adapter, enum hal_def_variable variable,
-               void *value);
 u8 GetHalDefVar(struct adapter *adapter, enum hal_def_variable variable,
                void *value);
 

diff --git a/drivers/staging/rtl8723bs/include/hal_intf.h b/drivers/staging/rtl8723bs/include/hal_intf.h
index 2fa2382ad5f37413046071efdb2f5885de04c2aa..82b60899129d078009bffde5fef3043fc638d902 100644 (file)
--- a/drivers/staging/rtl8723bs/include/hal_intf.h
+++ b/drivers/staging/rtl8723bs/include/hal_intf.h
@@ -199,7 +199,6 @@ void rtw_hal_chip_configure(struct adapter *padapter);
 void rtw_hal_read_chip_info(struct adapter *padapter);
 void rtw_hal_read_chip_version(struct adapter *padapter);
 
-u8 rtw_hal_set_def_var(struct adapter *padapter, enum hal_def_variable eVariable, void *pValue);
 u8 rtw_hal_get_def_var(struct adapter *padapter, enum hal_def_variable eVariable, void *pValue);
 
 void rtw_hal_set_odm_var(struct adapter *padapter, enum hal_odm_variable eVariable, void *pValue1, bool bSet);
@@ -262,7 +261,6 @@ void SetHwReg8723BS(struct adapter *padapter, u8 variable, u8 *val);
 void GetHwReg8723BS(struct adapter *padapter, u8 variable, u8 *val);
 void SetHwRegWithBuf8723B(struct adapter *padapter, u8 variable, u8 *pbuf, int len);
 u8 GetHalDefVar8723BSDIO(struct adapter *Adapter, enum hal_def_variable eVariable, void *pValue);
-u8 SetHalDefVar8723BSDIO(struct adapter *Adapter, enum hal_def_variable eVariable, void *pValue);
 void UpdateHalRAMask8723B(struct adapter *padapter, u32 mac_id, u8 rssi_level);
 void rtl8723b_SetBeaconRelatedRegisters(struct adapter *padapter);
 void Hal_EfusePowerSwitch(struct adapter *padapter, u8 PwrState);

diff --git a/drivers/staging/rtl8723bs/include/rtl8723b_hal.h b/drivers/staging/rtl8723bs/include/rtl8723b_hal.h
index 2ed1fc8549ec7034e3c2f27cdeb5fac44b0b2936..06e0a549fa9d93d5787ece93b5b7d99e6f9e1268 100644 (file)
--- a/drivers/staging/rtl8723bs/include/rtl8723b_hal.h
+++ b/drivers/staging/rtl8723bs/include/rtl8723b_hal.h
@@ -223,8 +223,6 @@ void C2HPacketHandler_8723B(struct adapter *padapter, u8 *pbuffer, u16 length);
 
 void SetHwReg8723B(struct adapter *padapter, u8 variable, u8 *val);
 void GetHwReg8723B(struct adapter *padapter, u8 variable, u8 *val);
-u8 SetHalDefVar8723B(struct adapter *padapter, enum hal_def_variable variable,
-                    void *pval);
 u8 GetHalDefVar8723B(struct adapter *padapter, enum hal_def_variable variable,
                     void *pval);