]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
OPP: of: Simplify with scoped for each OF child loop
authorKrzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Fri, 2 Jan 2026 12:49:14 +0000 (13:49 +0100)
committerViresh Kumar <viresh.kumar@linaro.org>
Mon, 5 Jan 2026 05:11:18 +0000 (10:41 +0530)
Use scoped for-each loop when iterating over device nodes to make code a
bit simpler.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
drivers/opp/of.c

index 1e0d0adb18e1ab72f9578a8eb0e6cbbcb02f2de2..a268c2b250c0daf0f305573b3644d1b74fa0672e 100644 (file)
@@ -956,7 +956,6 @@ free_opp:
 /* Initializes OPP tables based on new bindings */
 static int _of_add_opp_table_v2(struct device *dev, struct opp_table *opp_table)
 {
-       struct device_node *np;
        int ret, count = 0;
        struct dev_pm_opp *opp;
 
@@ -971,13 +970,12 @@ static int _of_add_opp_table_v2(struct device *dev, struct opp_table *opp_table)
        }
 
        /* We have opp-table node now, iterate over it and add OPPs */
-       for_each_available_child_of_node(opp_table->np, np) {
+       for_each_available_child_of_node_scoped(opp_table->np, np) {
                opp = _opp_add_static_v2(opp_table, dev, np);
                if (IS_ERR(opp)) {
                        ret = PTR_ERR(opp);
                        dev_err(dev, "%s: Failed to add OPP, %d\n", __func__,
                                ret);
-                       of_node_put(np);
                        goto remove_static_opp;
                } else if (opp) {
                        count++;