]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
soc: qcom: Use str_enable_disable-like helpers
authorKrzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Tue, 14 Jan 2025 20:36:46 +0000 (21:36 +0100)
committerBjorn Andersson <andersson@kernel.org>
Wed, 5 Feb 2025 03:16:36 +0000 (21:16 -0600)
Replace ternary (condition ? "enable" : "disable") syntax with helpers
from string_choices.h because:
1. Simple function call with one argument is easier to read.  Ternary
   operator has three arguments and with wrapping might lead to quite
   long code.
2. Is slightly shorter thus also easier to read.
3. It brings uniformity in the text - same string.
4. Allows deduping by the linker, which results in a smaller binary
   file.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Link: https://lore.kernel.org/r/20250114203646.1013708-1-krzysztof.kozlowski@linaro.org
Signed-off-by: Bjorn Andersson <andersson@kernel.org>
drivers/soc/qcom/qcom_aoss.c

index 0320ad3b91483db5b7d2b725ecd139349ee97500..a543ab9bee6c4efcbd7026c44af9731176d4d60c 100644 (file)
@@ -12,6 +12,7 @@
 #include <linux/platform_device.h>
 #include <linux/thermal.h>
 #include <linux/slab.h>
+#include <linux/string_choices.h>
 #include <linux/soc/qcom/qcom_aoss.h>
 
 #define CREATE_TRACE_POINTS
@@ -358,7 +359,7 @@ static int qmp_cdev_set_cur_state(struct thermal_cooling_device *cdev,
                return 0;
 
        ret = qmp_send(qmp_cdev->qmp, "{class: volt_flr, event:zero_temp, res:%s, value:%s}",
-                      qmp_cdev->name, cdev_state ? "on" : "off");
+                      qmp_cdev->name, str_on_off(cdev_state));
        if (!ret)
                qmp_cdev->state = cdev_state;