FDWrapper: Propery handle a negative descriptor in the move assignement operator

Reported by Coverity in CID 1462392.

diff --git a/pdns/misc.hh b/pdns/misc.hh
index 6307293f55cb91bd934da9192e6d003ee4d39c3b..c31df9ca4f00b45acf1137103440b7568859965c 100644 (file)
--- a/pdns/misc.hh
+++ b/pdns/misc.hh
@@ -663,7 +663,7 @@ struct FDWrapper
 
   FDWrapper& operator=(FDWrapper&& rhs)
   {
-    if (d_fd) {
+    if (d_fd != -1) {
       close(d_fd);
     }
     d_fd = rhs.d_fd;