]> git.ipfire.org Git - thirdparty/freeradius-server.git/commitdiff
fall through if there's no error
authorAlan T. DeKok <aland@freeradius.org>
Fri, 30 Aug 2019 15:36:45 +0000 (11:36 -0400)
committerAlan T. DeKok <aland@freeradius.org>
Fri, 30 Aug 2019 15:37:17 +0000 (11:37 -0400)
src/main/tls.c

index 6072072fced6eda1aad715a0a95f47600a7a3122..db733996661f24858ff47f18119917b3961aae0f 100644 (file)
@@ -3940,12 +3940,12 @@ fr_tls_status_t tls_application_data(tls_session_t *ssn, REQUEST *request)
                code = SSL_get_error(ssn->ssl, err);
                switch (code) {
                case SSL_ERROR_WANT_READ:
-                       DEBUG("Error in fragmentation logic: SSL_WANT_READ");
+                       RDEBUG("Error in fragmentation logic: SSL_WANT_READ");
                        return FR_TLS_MORE_FRAGMENTS;
 
                case SSL_ERROR_WANT_WRITE:
-                       DEBUG("Error in fragmentation logic: SSL_WANT_WRITE");
-                       break;
+                       RDEBUG("Error in fragmentation logic: SSL_WANT_WRITE");
+                       return FR_TLS_FAIL;
 
                case SSL_ERROR_NONE:
                        RDEBUG2("No application data received.  Assuming handshake is continuing...");
@@ -3956,9 +3956,8 @@ fr_tls_status_t tls_application_data(tls_session_t *ssn, REQUEST *request)
                        REDEBUG("Error in fragmentation logic");
                        tls_error_io_log(request, ssn, err,
                                         "Failed in " STRINGIFY(__FUNCTION__) " (SSL_read)");
-                       break;
+                       return FR_TLS_FAIL;
                }
-               return FR_TLS_FAIL;
        }
 
        /*