]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
octeontx2-pf: handle otx2_mbox_get_rsp errors in otx2_dcbnl.c
authorDipendra Khadka <kdipendra88@gmail.com>
Thu, 17 Oct 2024 19:16:16 +0000 (19:16 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 5 Dec 2024 12:53:16 +0000 (13:53 +0100)
[ Upstream commit 69297b0d3369488af259e3a7cf53d69157938ea1 ]

Add error pointer check after calling otx2_mbox_get_rsp().

Fixes: 8e67558177f8 ("octeontx2-pf: PFC config support with DCBx")
Signed-off-by: Dipendra Khadka <kdipendra88@gmail.com>
Reviewed-by: Simon Horman <horms@kernel.org>
Signed-off-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/net/ethernet/marvell/octeontx2/nic/otx2_dcbnl.c

index aa01110f04a339e9789902cccd7b67519f9a5aab..294fba58b670954855a4c9ed18ea1e2095b54a8e 100644 (file)
@@ -315,6 +315,11 @@ int otx2_config_priority_flow_ctrl(struct otx2_nic *pfvf)
        if (!otx2_sync_mbox_msg(&pfvf->mbox)) {
                rsp = (struct cgx_pfc_rsp *)
                       otx2_mbox_get_rsp(&pfvf->mbox.mbox, 0, &req->hdr);
+               if (IS_ERR(rsp)) {
+                       err = PTR_ERR(rsp);
+                       goto unlock;
+               }
+
                if (req->rx_pause != rsp->rx_pause || req->tx_pause != rsp->tx_pause) {
                        dev_warn(pfvf->dev,
                                 "Failed to config PFC\n");