]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
ASoC: codecs: pm4125: drop bogus container_of() error handling
authorJohan Hovold <johan@kernel.org>
Fri, 19 Dec 2025 14:27:13 +0000 (15:27 +0100)
committerMark Brown <broonie@kernel.org>
Mon, 22 Dec 2025 09:14:51 +0000 (09:14 +0000)
The dev_to_sdw_dev() helper uses container_of() to return the containing
soundwire device structure of its pointer argument and will never return
NULL.

Fixes: 8ad529484937 ("ASoC: codecs: add new pm4125 audio codec driver")
Cc: Alexey Klimov <alexey.klimov@linaro.org>
Signed-off-by: Johan Hovold <johan@kernel.org>
Acked-by: Alexey Klimov <alexey.klimov@linaro.org>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Link: https://patch.msgid.link/20251219142715.19254-2-johan@kernel.org
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/codecs/pm4125.c

index 8bc3b999401975b09f4a83d5139d46eb52d124df..4798cd8be9f89559af41a97ca2cdac243cbadfca 100644 (file)
@@ -1537,13 +1537,7 @@ static int pm4125_bind(struct device *dev)
 
        pm4125->sdw_priv[AIF1_CAP] = dev_get_drvdata(pm4125->txdev);
        pm4125->sdw_priv[AIF1_CAP]->pm4125 = pm4125;
-
        pm4125->tx_sdw_dev = dev_to_sdw_dev(pm4125->txdev);
-       if (!pm4125->tx_sdw_dev) {
-               dev_err(dev, "could not get txslave with matching of dev\n");
-               ret = -EINVAL;
-               goto error_put_tx;
-       }
 
        /*
         * As TX is the main CSR reg interface, which should not be suspended first.