]> git.ipfire.org Git - thirdparty/libnftnl.git/commitdiff
expr: data_reg: Fix DATA_CHAIN comparison
authorCarlos Falgueras García <carlosfg@riseup.net>
Wed, 24 Aug 2016 12:22:16 +0000 (14:22 +0200)
committerPablo Neira Ayuso <pablo@netfilter.org>
Wed, 24 Aug 2016 15:05:08 +0000 (17:05 +0200)
Split DATA_VERDICT and DATA_CHAIN comparison. A verdict can have a NULL
chain (accept, drop, etc) so segfault will happen when strcmp is called.

Signed-off-by: Carlos Falgueras García <carlosfg@riseup.net>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
src/expr/data_reg.c

index a954e9539957fef47dab94505e1dad6c4648dbb2..395e9f656ca85f57a8ff922bfcff7bd61b649b57 100644 (file)
@@ -387,6 +387,7 @@ bool nftnl_data_reg_cmp(const union nftnl_data_reg *r1,
                return  r1->len == r2->len &&
                        !memcmp(r1->val, r2->val, r1->len);
        case DATA_VERDICT:
+               return  r1->verdict == r2->verdict;
        case DATA_CHAIN:
                return  r1->verdict == r2->verdict &&
                        !strcmp(r1->chain, r2->chain);