loadparm: Set default of "kernel share modes" to "no"

selftest: Remove knownfail for smb2.lock.replay_smb3_specification_durable

With the changed default for "kernel share modes", this test can now
acquire durable handles and succeed.

Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>

diff --git a/lib/param/loadparm.c b/lib/param/loadparm.c
index 59e749d9d46fe09f5f99b5e7e7145427a04ef542..2eac1ba7c3884d48c8787ff189f45ba0abb45fb8 100644 (file)
--- a/lib/param/loadparm.c
+++ b/lib/param/loadparm.c
@@ -2808,7 +2808,7 @@ struct loadparm_context *loadparm_init(TALLOC_CTX *mem_ctx)
 
        lpcfg_do_global_parameter(lp_ctx, "ldap page size", "1000");
 
-       lpcfg_do_global_parameter(lp_ctx, "kernel share modes", "yes");
+       lpcfg_do_global_parameter(lp_ctx, "kernel share modes", "no");
 
        lpcfg_do_global_parameter(lp_ctx, "strict locking", "Auto");
 

diff --git a/selftest/knownfail b/selftest/knownfail
index 9f362c02b470fcbc38fb3756d2812c039b179ac8..73ae71425638cc88c88363497b2c409219a003f3 100644 (file)
--- a/selftest/knownfail
+++ b/selftest/knownfail
@@ -215,7 +215,6 @@
 ^samba3.smb2.session.*reauth5 # some special anonymous checks?
 ^samba3.smb2.compound.interim2 # wrong return code (STATUS_CANCELLED)
 ^samba3.smb2.compound.aio.interim2 # wrong return code (STATUS_CANCELLED)
-^samba3.smb2.lock.replay_smb3_specification_durable\(nt4_dc\) # Requires durable handles
 ^samba3.smb2.lock.*replay_broken_windows # This tests the windows behaviour
 ^samba3.smb2.lease.statopen3
 ^samba3.smb2.lease.unlink # we currently do not downgrade RH lease to R after unlink

diff --git a/source3/param/loadparm.c b/source3/param/loadparm.c
index b003e54c038ad591886781db4f2df1498bfe8af5..6c9830563c3bb168526e856196008473c014e434 100644 (file)
--- a/source3/param/loadparm.c
+++ b/source3/param/loadparm.c
@@ -246,7 +246,7 @@ static const struct loadparm_service _sDefault =
        .map_readonly = MAP_READONLY_NO,
        .directory_name_cache_size = 100,
        .server_smb_encrypt = SMB_ENCRYPTION_DEFAULT,
-       .kernel_share_modes = true,
+       .kernel_share_modes = false,
        .durable_handles = true,
        .check_parent_directory_delete_on_close = false,
        .param_opt = NULL,