]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
mmc: rtsx_usb_sdmmc: Convert sd_set_power_mode() into void
authorUlf Hansson <ulf.hansson@linaro.org>
Tue, 10 Jun 2025 11:16:25 +0000 (13:16 +0200)
committerUlf Hansson <ulf.hansson@linaro.org>
Tue, 24 Jun 2025 10:43:26 +0000 (12:43 +0200)
The sdmmc_set_ios() is the only caller of sd_set_power_mode() and it
ignores the return code. Let's therefore convert sd_set_power_mode() into a
void function instead.

Reviewed-by: Avri Altman <avri.altman@sandisk.com>
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
Acked-by: Ricky Wu <ricky_wu@realtek.com>
Link: https://lore.kernel.org/r/20250610111633.504366-4-ulf.hansson@linaro.org
drivers/mmc/host/rtsx_usb_sdmmc.c

index 0e2aac8dd59ea55e96d4ca80e4867539e6c25441..676f08f71ec0927e9bf7f938fad14b76f5932379 100644 (file)
@@ -1010,7 +1010,7 @@ static int sd_power_off(struct rtsx_usb_sdmmc *host)
        return sd_pull_ctl_disable_qfn24(ucr);
 }
 
-static int sd_set_power_mode(struct rtsx_usb_sdmmc *host,
+static void sd_set_power_mode(struct rtsx_usb_sdmmc *host,
                unsigned char power_mode)
 {
        int err;
@@ -1019,7 +1019,7 @@ static int sd_set_power_mode(struct rtsx_usb_sdmmc *host,
                power_mode = MMC_POWER_ON;
 
        if (power_mode == host->power_mode)
-               return 0;
+               return;
 
        if (power_mode == MMC_POWER_OFF) {
                err = sd_power_off(host);
@@ -1034,7 +1034,6 @@ static int sd_set_power_mode(struct rtsx_usb_sdmmc *host,
        }
 
        host->power_mode = power_mode;
-       return err;
 }
 
 static int sd_set_timing(struct rtsx_usb_sdmmc *host,