mm/damon/tests/core-kunit: handle alloc failures on damon_test_split_regions_of()

commit eded254cb69044bd4abde87394ea44909708d7c0 upstream.

damon_test_split_regions_of() is assuming all dynamic memory allocation in
it will succeed.  Those are indeed likely in the real use cases since
those allocations are too small to fail, but theoretically those could
fail.  In the case, inappropriate memory access can happen.  Fix it by
appropriately cleanup pre-allocated memory and skip the execution of the
remaining tests in the failure cases.

Link: https://lkml.kernel.org/r/20251101182021.74868-9-sj@kernel.org
Fixes: 17ccae8bb5c9 ("mm/damon: add kunit tests")
Signed-off-by: SeongJae Park <sj@kernel.org>
Cc: Brendan Higgins <brendan.higgins@linux.dev>
Cc: David Gow <davidgow@google.com>
Cc: Kefeng Wang <wangkefeng.wang@huawei.com>
Cc: <stable@vger.kernel.org>	[5.15+]
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/mm/damon/core-test.h b/mm/damon/core-test.h
index 4f31ac6f6d89b2d7562a3d5b3f82bf3cc88fc60d..130cbfc5af450610605046c0cc2fa5c745da836d 100644 (file)
--- a/mm/damon/core-test.h
+++ b/mm/damon/core-test.h
@@ -255,15 +255,36 @@ static void damon_test_split_regions_of(struct kunit *test)
        struct damon_target *t;
        struct damon_region *r;
 
+       if (!c)
+               kunit_skip(test, "ctx alloc fail");
+
        t = damon_new_target(42);
+       if (!t) {
+               damon_destroy_ctx(c);
+               kunit_skip(test, "target alloc fail");
+       }
        r = damon_new_region(0, 22);
+       if (!r) {
+               damon_destroy_ctx(c);
+               damon_free_target(t);
+               kunit_skip(test, "region alloc fail");
+       }
        damon_add_region(r, t);
        damon_split_regions_of(c, t, 2);
        KUNIT_EXPECT_LE(test, damon_nr_regions(t), 2u);
        damon_free_target(t);
 
        t = damon_new_target(42);
+       if (!t) {
+               damon_destroy_ctx(c);
+               kunit_skip(test, "second target alloc fail");
+       }
        r = damon_new_region(0, 220);
+       if (!r) {
+               damon_destroy_ctx(c);
+               damon_free_target(t);
+               kunit_skip(test, "second region alloc fail");
+       }
        damon_add_region(r, t);
        damon_split_regions_of(c, t, 4);
        KUNIT_EXPECT_LE(test, damon_nr_regions(t), 4u);