diagnostics: bulletproof html_builder::make_metadata_element

gcc/ChangeLog:
	* diagnostic-format-html.cc (html_builder::make_metadata_element):
	Gracefully handle the case where "url" is null.

Signed-off-by: David Malcolm <dmalcolm@redhat.com>

diff --git a/gcc/diagnostic-format-html.cc b/gcc/diagnostic-format-html.cc
index f2b255bf9cd2088a3593e28d7d1ce059e328e82f..3fa5e662d2bece13a279cd95538a0aa7dffb663e 100644 (file)
--- a/gcc/diagnostic-format-html.cc
+++ b/gcc/diagnostic-format-html.cc
@@ -897,10 +897,14 @@ html_builder::make_metadata_element (label_text label,
   xml::printer xp (*item.get ());
   xp.add_text ("[");
   {
-    xp.push_tag ("a", true);
-    xp.set_attr ("href", url.get ());
+    if (url.get ())
+      {
+       xp.push_tag ("a", true);
+       xp.set_attr ("href", url.get ());
+      }
     xp.add_text (label.get ());
-    xp.pop_tag ();
+    if (url.get ())
+      xp.pop_tag ();
   }
   xp.add_text ("]");
   return item;