- Fix fix for #78 to also free service callback struct.

diff --git a/doc/Changelog b/doc/Changelog
index c66e0c65fedad702726fa342562ee0c4a8e22351..22f1aaa730d0394f52619632084cacf411d2d273 100644 (file)
--- a/doc/Changelog
+++ b/doc/Changelog
@@ -3,6 +3,7 @@
        - Merge pull request #76 from Maryse47: Improvements and fixes for
          systemd unbound.service.
        - oss-fuzz badge on README.md.
+       - Fix fix for #78 to also free service callback struct.
 
 11 September 2019: Wouter
        - Use explicit bzero for wiping clear buffer of hash in cachedb,

diff --git a/services/outside_network.c b/services/outside_network.c
index bb91f57f6774e1d511da457e6b18f5d62074fadd..f865f13c1390c7ca9b58559f7d0761c069695423 100644 (file)
--- a/services/outside_network.c
+++ b/services/outside_network.c
@@ -2135,12 +2135,14 @@ outnet_serviced_query(struct outside_network* outnet,
                        if(!serviced_udp_send(sq, buff)) {
                                (void)rbtree_delete(outnet->serviced, sq);
                                serviced_node_del(&sq->node, NULL);
+                               free(cb);
                                return NULL;
                        }
                } else {
                        if(!serviced_tcp_send(sq, buff)) {
                                (void)rbtree_delete(outnet->serviced, sq);
                                serviced_node_del(&sq->node, NULL);
+                               free(cb);
                                return NULL;
                        }
                }