]> git.ipfire.org Git - thirdparty/dovecot/core.git/commitdiff
lib-sasl: dsasl-client-mech-gssapi - Remove unused security layer negotiation code
authorStephan Bosch <stephan.bosch@open-xchange.com>
Thu, 9 Oct 2025 23:36:05 +0000 (01:36 +0200)
committerStephan Bosch <stephan.bosch@open-xchange.com>
Thu, 9 Oct 2025 23:37:35 +0000 (01:37 +0200)
Fix for scan-build-19 report.

src/lib-sasl/dsasl-client-mech-gssapi.c

index 4b0799365d9179b3faef476ed5c93c1090b64472..74821cb6a59ff97df4e388fab5195314a5032eaf 100644 (file)
@@ -215,7 +215,6 @@ mech_gssapi_gs1_unwrap(struct gssapi_sasl_client *gclient,
        gss_qop_t qop = GSS_C_QOP_DEFAULT;
        unsigned char *data;
        unsigned int sec_layer = 0;
-       unsigned int max_size = 0;
        buffer_t *buf;
        size_t authzid_size = (client->set.authzid == NULL ?
                               0 : strlen(client->set.authzid));
@@ -237,7 +236,6 @@ mech_gssapi_gs1_unwrap(struct gssapi_sasl_client *gclient,
 
        data = out_buf.value;
        sec_layer = data[0];
-       max_size = (data[1] << 16) | (data[2] << 8) | data[3];
        (void)gss_release_buffer(&minor_status, &out_buf);
 
        /* Check server parameters */
@@ -246,13 +244,12 @@ mech_gssapi_gs1_unwrap(struct gssapi_sasl_client *gclient,
                return DSASL_CLIENT_RESULT_ERR_PROTOCOL;
        }
        sec_layer = SASL_GSSAPI_QOP_AUTH_ONLY;
-       max_size = 0;
-
+       
        buf = t_buffer_create(4 + authzid_size);
        buffer_append_c(buf, sec_layer);
-       buffer_append_c(buf, max_size >> 16);
-       buffer_append_c(buf, max_size >> 8);
-       buffer_append_c(buf, max_size >> 0);
+       buffer_append_c(buf, 0);
+       buffer_append_c(buf, 0);
+       buffer_append_c(buf, 0);
        if (client->set.authzid != NULL)
                buffer_append(buf, client->set.authzid, authzid_size);