]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
storage: Don't report OOM error on failure of glfs_new
authorPeter Krempa <pkrempa@redhat.com>
Wed, 24 Feb 2021 09:22:52 +0000 (10:22 +0100)
committerPeter Krempa <pkrempa@redhat.com>
Tue, 2 Mar 2021 08:50:20 +0000 (09:50 +0100)
OOM isn't the only failure glfs_new can encounter. Report an error which
might give more insight. libgfapi seems to be setting errno but
reporting a system error migt be misleading.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Laine Stump <laine@redhat.com>
src/storage/storage_backend_gluster.c
src/storage_file/storage_file_backend_gluster.c

index 8de0cb8a6bbe4b57ccb840b3550f2d169fa02c2d..e673922df6dd51d0eea95d8b8df5dcaa4981cb51 100644 (file)
@@ -114,7 +114,8 @@ virStorageBackendGlusterOpen(virStoragePoolObjPtr pool)
 
     /* Actually connect to glfs */
     if (!(ret->vol = glfs_new(ret->volname))) {
-        virReportOOMError();
+        virReportError(VIR_ERR_OPERATION_FAILED,
+                       _("failed to create glfs object for '%s'"), ret->volname);
         goto error;
     }
 
index 9b3b783274e954932fd5dc4cec6747d817aa8031..8c7a583886b6ee0cf97e96387acb60de12ccf3d7 100644 (file)
@@ -120,7 +120,8 @@ virStorageFileBackendGlusterInit(virStorageSourcePtr src)
               (unsigned int)drv->uid, (unsigned int)drv->gid);
 
     if (!(priv->vol = glfs_new(src->volume))) {
-        virReportOOMError();
+        virReportError(VIR_ERR_OPERATION_FAILED,
+                       _("failed to create glfs object for '%s'"), src->volume);
         goto error;
     }