]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
net: ethernet: adi: adin1110: Fix uninitialized variable
authorDell Jin <dell.jin.code@outlook.com>
Fri, 20 Oct 2023 06:20:53 +0000 (09:20 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 2 Nov 2023 08:35:27 +0000 (09:35 +0100)
[ Upstream commit 965f9b8c0c1b37fa2a0e3ef56e40d5666d4cbb5c ]

The spi_transfer struct has to have all it's fields initialized to 0 in
this case, since not all of them are set before starting the transfer.
Otherwise, spi_sync_transfer() will sometimes return an error.

Fixes: a526a3cc9c8d ("net: ethernet: adi: adin1110: Fix SPI transfers")
Signed-off-by: Dell Jin <dell.jin.code@outlook.com>
Signed-off-by: Ciprian Regus <ciprian.regus@analog.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/net/ethernet/adi/adin1110.c

index ed2863ed6a5bbb8d6c235fbec0f525b04364733e..7474afc0e8e737800cfa0f8ed33180ed2c8f4cc3 100644 (file)
@@ -294,7 +294,7 @@ static int adin1110_read_fifo(struct adin1110_port_priv *port_priv)
 {
        struct adin1110_priv *priv = port_priv->priv;
        u32 header_len = ADIN1110_RD_HEADER_LEN;
-       struct spi_transfer t;
+       struct spi_transfer t = {0};
        u32 frame_size_no_fcs;
        struct sk_buff *rxb;
        u32 frame_size;