]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
ssb: use new GPIO line value setter callbacks for the second GPIO chip
authorBartosz Golaszewski <bartosz.golaszewski@linaro.org>
Wed, 23 Jul 2025 14:12:57 +0000 (16:12 +0200)
committerJohannes Berg <johannes.berg@intel.com>
Thu, 24 Jul 2025 07:06:46 +0000 (09:06 +0200)
Because the other chip is guarded in an unlikely ifdef, I missed it when
converting this driver. Fix it now.

Fixes: 757259db79fc ("ssb: use new GPIO line value setter callbacks")
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Link: https://patch.msgid.link/20250723141257.51412-1-brgl@bgdev.pl
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
drivers/ssb/driver_gpio.c

index 14ad57954a662383ec0f0741835da55cbd21a44e..e1f5f0a9c8a219d6652960b559a4e80460c7b679 100644 (file)
@@ -267,12 +267,14 @@ static int ssb_gpio_extif_get_value(struct gpio_chip *chip, unsigned int gpio)
        return !!ssb_extif_gpio_in(&bus->extif, 1 << gpio);
 }
 
-static void ssb_gpio_extif_set_value(struct gpio_chip *chip, unsigned int gpio,
-                                    int value)
+static int ssb_gpio_extif_set_value(struct gpio_chip *chip, unsigned int gpio,
+                                   int value)
 {
        struct ssb_bus *bus = gpiochip_get_data(chip);
 
        ssb_extif_gpio_out(&bus->extif, 1 << gpio, value ? 1 << gpio : 0);
+
+       return 0;
 }
 
 static int ssb_gpio_extif_direction_input(struct gpio_chip *chip,
@@ -420,7 +422,7 @@ static int ssb_gpio_extif_init(struct ssb_bus *bus)
        chip->label             = "ssb_extif_gpio";
        chip->owner             = THIS_MODULE;
        chip->get               = ssb_gpio_extif_get_value;
-       chip->set               = ssb_gpio_extif_set_value;
+       chip->set_rv            = ssb_gpio_extif_set_value;
        chip->direction_input   = ssb_gpio_extif_direction_input;
        chip->direction_output  = ssb_gpio_extif_direction_output;
 #if IS_ENABLED(CONFIG_SSB_EMBEDDED)