]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
platform/x86/intel/pmc: use kcalloc() instead of kzalloc()
authorQianfeng Rong <rongqianfeng@vivo.com>
Tue, 19 Aug 2025 13:51:55 +0000 (21:51 +0800)
committerIlpo Järvinen <ilpo.jarvinen@linux.intel.com>
Thu, 28 Aug 2025 11:53:35 +0000 (14:53 +0300)
Replace devm_kzalloc() with devm_kcalloc() in pmc_core_get_tgl_lpm_reqs().
As noted in the kernel documentation [1], open-coded multiplication in
allocator arguments is discouraged because it can lead to integer
overflow.

Using devm_kcalloc() provides built-in overflow protection, making the
memory allocation safer when calculating the allocation size compared
to explicit multiplication.

[1]: https://www.kernel.org/doc/html/next/process/deprecated.html#open-coded-arithmetic-in-allocator-arguments

Signed-off-by: Qianfeng Rong <rongqianfeng@vivo.com>
Acked-by: David E. Box <david.e.box@intel.com>
Link: https://lore.kernel.org/r/20250819135155.338380-1-rongqianfeng@vivo.com
Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
drivers/platform/x86/intel/pmc/tgl.c

index 02e731ed3391418fab0c0d1a0b20dd59531e1278..fc5b4cacc1c62baebd60e23df82bc655cef745db 100644 (file)
@@ -273,8 +273,8 @@ void pmc_core_get_tgl_lpm_reqs(struct platform_device *pdev)
 
        addr = (u32 *)out_obj->buffer.pointer;
 
-       lpm_req_regs = devm_kzalloc(&pdev->dev, lpm_size * sizeof(u32),
-                                    GFP_KERNEL);
+       lpm_req_regs = devm_kcalloc(&pdev->dev, lpm_size, sizeof(u32),
+                                   GFP_KERNEL);
        if (!lpm_req_regs)
                goto free_acpi_obj;