]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
net: thunder: Check for driver data in nicvf_remove()
authorPavel Fedin <p.fedin@samsung.com>
Mon, 16 Nov 2015 14:51:34 +0000 (17:51 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 15 Dec 2015 05:25:36 +0000 (21:25 -0800)
[ Upstream commit 7750130d93decff06120df0d8ea024ff8a038a21 ]

In some cases the crash is caused by nicvf_remove() being called from
outside. For example, if we try to feed the device to vfio after the
probe has failed for some reason. So, move the check to better place.

Signed-off-by: Pavel Fedin <p.fedin@samsung.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/net/ethernet/cavium/thunder/nicvf_main.c

index 3b90afb8c293254e999f76f3ebbfbd0108dd7022..6f2a748524f3cc2a4cabe013989926cb1930f284 100644 (file)
@@ -1325,7 +1325,12 @@ err_disable_device:
 static void nicvf_remove(struct pci_dev *pdev)
 {
        struct net_device *netdev = pci_get_drvdata(pdev);
-       struct nicvf *nic = netdev_priv(netdev);
+       struct nicvf *nic;
+
+       if (!netdev)
+               return;
+
+       nic = netdev_priv(netdev);
 
        unregister_netdev(netdev);
        nicvf_unregister_interrupts(nic);