]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
qemu_driver: avoid NULL dereference
authorJim Meyering <meyering@redhat.com>
Mon, 17 May 2010 10:10:52 +0000 (12:10 +0200)
committerJim Meyering <meyering@redhat.com>
Mon, 17 May 2010 11:47:45 +0000 (13:47 +0200)
* src/qemu/qemu_driver.c (qemudDomainStart): After setting vm to NULL,
goto cleanup, rather than dereferencing the NULL pointer.

src/qemu/qemu_driver.c

index fabd41b95c25f7d3365b742293548f91907290cd..5f1d6b59f4d3890fcaefbd466cd60c3fa102dda9 100644 (file)
@@ -6489,8 +6489,11 @@ static int qemudDomainStart(virDomainPtr dom) {
          * We should still have a reference left to vm but
          * one should check for 0 anyway
          */
-        if (qemuDomainObjEndJob(vm) == 0)
+        if (qemuDomainObjEndJob(vm) = 0) {
             vm = NULL;
+            goto cleanup;
+        }
+
         virDomainObjUnlock(vm);
         qemuDriverUnlock(driver);
         ret = qemudDomainRestore(dom->conn, managed_save);