]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
media: amphion: Drop min_queued_buffers assignment
authorMing Qian <ming.qian@oss.nxp.com>
Tue, 23 Dec 2025 06:27:52 +0000 (14:27 +0800)
committerHans Verkuil <hverkuil+cisco@kernel.org>
Tue, 13 Jan 2026 08:41:59 +0000 (09:41 +0100)
The min_queued_buffers field controls when start_streaming() is called
by the vb2 core (it delays the callback until at least N buffers are
queued). Setting it to 1 affects the timing of start_streaming(), which
breaks the seek flow in decoder scenarios and causes test failures.

The current driver implementation does not rely on this minimum buffer
requirement and handles streaming start correctly with the default
value of 0, so remove these assignments.

Fixes: 3cd084519c6f ("media: amphion: add vpu v4l2 m2m support")
Cc: stable@vger.kernel.org
Signed-off-by: Ming Qian <ming.qian@oss.nxp.com>
Reviewed-by: Nicolas Dufresne <nicolas.dufresne@collabora.com>
Reviewed-by: Frank Li <Frank.Li@nxp.com>
Signed-off-by: Nicolas Dufresne <nicolas.dufresne@collabora.com>
Signed-off-by: Hans Verkuil <hverkuil+cisco@kernel.org>
drivers/media/platform/amphion/vpu_v4l2.c

index 121165a7184fc999b33da9ac002972b0c5a986bf..64fc88d89cccdc80e2e5e0c687f1914c14ad9cce 100644 (file)
@@ -669,7 +669,6 @@ static int vpu_m2m_queue_init(void *priv, struct vb2_queue *src_vq, struct vb2_q
                src_vq->mem_ops = &vb2_vmalloc_memops;
        src_vq->drv_priv = inst;
        src_vq->buf_struct_size = sizeof(struct vpu_vb2_buffer);
-       src_vq->min_queued_buffers = 1;
        src_vq->dev = inst->vpu->dev;
        src_vq->lock = &inst->lock;
        ret = vb2_queue_init(src_vq);
@@ -686,7 +685,6 @@ static int vpu_m2m_queue_init(void *priv, struct vb2_queue *src_vq, struct vb2_q
                dst_vq->mem_ops = &vb2_vmalloc_memops;
        dst_vq->drv_priv = inst;
        dst_vq->buf_struct_size = sizeof(struct vpu_vb2_buffer);
-       dst_vq->min_queued_buffers = 1;
        dst_vq->dev = inst->vpu->dev;
        dst_vq->lock = &inst->lock;
        ret = vb2_queue_init(dst_vq);