staging: greybus: fix symbolic permission coding style issues

Fix "Octal permissions are preffered than symbolic ones" issues.

Signed-off-by: Gioh Kim <gi-oh.kim@profitbricks.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/drivers/staging/greybus/es2.c b/drivers/staging/greybus/es2.c
index 0eba059b3a9c1bbc09147520ee3b24f4c8613d2b..f7b24e0eaa6f34d93ee69e0fee78509eb2a22e96 100644 (file)
--- a/drivers/staging/greybus/es2.c
+++ b/drivers/staging/greybus/es2.c
@@ -1152,7 +1152,7 @@ static void usb_log_enable(struct es2_ap_dev *es2)
        if (IS_ERR(es2->apb_log_task))
                return;
        /* XXX We will need to rename this per APB */
-       es2->apb_log_dentry = debugfs_create_file("apb_log", S_IRUGO,
+       es2->apb_log_dentry = debugfs_create_file("apb_log", 0444,
                                                gb_debugfs_get(), es2,
                                                &apb_log_fops);
 }
@@ -1409,7 +1409,7 @@ static int ap_probe(struct usb_interface *interface,
 
        /* XXX We will need to rename this per APB */
        es2->apb_log_enable_dentry = debugfs_create_file("apb_log_enable",
-                                                       (S_IWUSR | S_IRUGO),
+                                                       0644,
                                                        gb_debugfs_get(), es2,
                                                        &apb_log_enable_fops);
 

diff --git a/drivers/staging/greybus/loopback.c b/drivers/staging/greybus/loopback.c
index 43692b86e0b21f0c7877a8c21b72f5422a2be0d2..aaf29a5fac8392cbcee5abcbf5b775f9bf6cf28e 100644 (file)
--- a/drivers/staging/greybus/loopback.c
+++ b/drivers/staging/greybus/loopback.c
@@ -1215,7 +1215,7 @@ static int gb_loopback_probe(struct gb_bundle *bundle,
        /* Create per-connection sysfs and debugfs data-points */
        snprintf(name, sizeof(name), "raw_latency_%s",
                 dev_name(&connection->bundle->dev));
-       gb->file = debugfs_create_file(name, S_IFREG | S_IRUGO, gb_dev.root, gb,
+       gb->file = debugfs_create_file(name, S_IFREG | 0444, gb_dev.root, gb,
                                       &gb_loopback_debugfs_latency_ops);
 
        gb->id = ida_simple_get(&loopback_ida, 0, 0, GFP_KERNEL);

diff --git a/drivers/staging/greybus/svc.c b/drivers/staging/greybus/svc.c
index 5549db2fc7490d5792452cc0b0f7e65186024cff..516f827e5ed9aea6cef086ffe10308236e4218fa 100644 (file)
--- a/drivers/staging/greybus/svc.c
+++ b/drivers/staging/greybus/svc.c
@@ -803,11 +803,11 @@ static void gb_svc_pwrmon_debugfs_init(struct gb_svc *svc)
                rail->svc = svc;
 
                dir = debugfs_create_dir(fname, dent);
-               debugfs_create_file("voltage_now", S_IRUGO, dir, rail,
+               debugfs_create_file("voltage_now", 0444, dir, rail,
                                    &pwrmon_debugfs_voltage_fops);
-               debugfs_create_file("current_now", S_IRUGO, dir, rail,
+               debugfs_create_file("current_now", 0444, dir, rail,
                                    &pwrmon_debugfs_current_fops);
-               debugfs_create_file("power_now", S_IRUGO, dir, rail,
+               debugfs_create_file("power_now", 0444, dir, rail,
                                    &pwrmon_debugfs_power_fops);
        }