]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
virbitmaptest: test13: Refactor memory cleanup
authorPeter Krempa <pkrempa@redhat.com>
Thu, 1 Oct 2020 14:16:21 +0000 (16:16 +0200)
committerPeter Krempa <pkrempa@redhat.com>
Mon, 5 Oct 2020 10:26:22 +0000 (12:26 +0200)
Move scope of variables and get rid of the 'cleanup' section.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
tests/virbitmaptest.c

index e1a49bfe356624b4d4671fae6ca9cee5a2f1a45e..996472ee3e9d231c17545fcb21b3da05e8c8bccc 100644 (file)
@@ -670,37 +670,27 @@ test12(const void *opaque G_GNUC_UNUSED)
 static int
 test13(const void *opaque G_GNUC_UNUSED)
 {
-    virBitmapPtr map = NULL;
     const char *strings[] = { "1234feebee", "000c0fefe" };
-    char *str = NULL;
     size_t i = 0;
-    int ret = -1;
 
     for (i = 0; i < G_N_ELEMENTS(strings); i++) {
-        map = virBitmapNewString(strings[i]);
-        if (!map)
-            goto cleanup;
+        g_autoptr(virBitmap) map = NULL;
+        g_autofree char *str = NULL;
 
-        str = virBitmapToString(map);
-        if (!str)
-            goto cleanup;
+        if (!(map = virBitmapNewString(strings[i])))
+            return -1;
+
+        if (!(str = virBitmapToString(map)))
+            return -1;
 
         if (STRNEQ(strings[i], str)) {
             fprintf(stderr, "\n expected bitmap string '%s' actual string "
                     "'%s'\n", strings[i], str);
-            goto cleanup;
+            return -1;
         }
-
-        VIR_FREE(str);
-        virBitmapFree(map);
-        map = NULL;
     }
 
-    ret = 0;
- cleanup:
-    VIR_FREE(str);
-    virBitmapFree(map);
-    return ret;
+    return 0;
 }
 
 #undef TEST_MAP